Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp3545952pxy; Tue, 4 May 2021 04:53:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxa2w4gJLhX35S7NbBso6vD8AHz5sUhMyWIE/TZZPWGCO5vFT9ogiXFohvFm3UYdOhwV/m X-Received: by 2002:a05:6a00:8c7:b029:20f:1cf4:d02 with SMTP id s7-20020a056a0008c7b029020f1cf40d02mr23820940pfu.49.1620129217213; Tue, 04 May 2021 04:53:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620129217; cv=none; d=google.com; s=arc-20160816; b=xfpjxzhvwak9Hi7azfDjvUSJDkDJq6Ck1oy9hgy186pSNPkJSdL0u5EVfheAH/3aDM p0Z1wk5ELjdz93c7hhTX6IA/qNVCguSnze6Kc5r4QWTaiV+ggkReFdBMmPiBvSWrNgMJ xGEO9rwPHE8d+YWvuQ9n+yBUkV7M+syIuFTcvqJ2AAo2POrGXvizmUrh6ZXKjBnB1Kpw r/02SDUHOjUXDcQ6MWw8zMNsL6vX5BSazWNRvVsWywjbI3MVHmgA9byBqPNfS/TN5gQ2 P7IIRS844UFUpCmT92zyllfwXh6fdyUXY3zgzjMuR6j2mvsHIhF+2MrwV/WdJnsszWsC R0fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=GW6GUuONPABrx2BFXGJh0SjTmP9t0U63hpuN8y3MW9g=; b=mIsQk1HYn9HbAfWz+kSUHrlP5XwL602oHxhn0gIWCNsUCHvLX6YZzd0AEoyiqYHaD+ ktXniGcgfizND5dQ811Sh9fOIjHOcwioFbkO7dnm6duq8obasP10UXeQFh7mgig4mvfP Bm5QpCEgSj/ehbmfHyC6ZY9AnbN/odungyeu+xKm85DjHUZ0QXBoqddge2r5IMO2mlkJ jfP8riGuRi688EylsmuggxX1DssuURkTC1gCD/qZaKK109GsCUYI77PMYhFAvqM2TuhG /xqpGB8nZrU7cFSZKnPPp4OFzHMoFHhZ+P9/H9Kgh5OxFhESkAkB4cyYOHVcOS+xOGIE uwyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=paTEGtC0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v6si3066742pju.127.2021.05.04.04.53.25; Tue, 04 May 2021 04:53:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=paTEGtC0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230089AbhEDLxK (ORCPT + 99 others); Tue, 4 May 2021 07:53:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230110AbhEDLxJ (ORCPT ); Tue, 4 May 2021 07:53:09 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7697EC061574 for ; Tue, 4 May 2021 04:52:14 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id v5so1973745ljg.12 for ; Tue, 04 May 2021 04:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=GW6GUuONPABrx2BFXGJh0SjTmP9t0U63hpuN8y3MW9g=; b=paTEGtC0YjJRHiY0XOtzrdDks/f7ssjpY2ykEb4lVja6Dqw4GK5Ga52klAdM+1Xw7q wYk4uJ3b66kTTbKWcExYHyV7cA6ddteEovzt2gq7WMb8k1tQQ+t+CZhER7EnYfCuVLyE gixMlraFmO9yfKx3OiiWGqbzYZZlZxOf3e2OHWIksJhCEvvXXF5XWCZGgHkfeV4+Elwh GFLYTE331XE1cE+y7dQ5fgbQHsaQ49Ibr8UQ8XuGj/A1Xj/Vx2rLBcsoniWxhsiyIHVP Xp63OAGUA4dE/iV8sNsZkXYE4o6EuWihVaPxnDP4v5joLhgNVGbLmlQGXPk7L2H+TGfP UbpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=GW6GUuONPABrx2BFXGJh0SjTmP9t0U63hpuN8y3MW9g=; b=tvgP5Pj879AN+B19THBW/lDmeHpQlSF6jWJ95RNVQb490mmSgN3HEO4xDNPZTsc5iA XFvGysDGYFPAlSbJk3F2MSMCod0aZXTrMr5nhX28D5FwUB+0OE3qNIJCUvxA4Vzu+Oen jlqhh+VCHQpFlO5Wrxw0Zg604yVB98XnXp5YP6FCRYzKczdgiYc2ofdlel+JYywposTm 9vhE9GiN2RF75CrZc10p1Fe2EGiZn1Du/nfPyH3d7N5dD/6S6NEFySLQgM9nfjIuF9Nd XT2WTx473QmVl5dIcEMPBu/SjC9Ta8jgydb27+pqW6b7VIUqwmlmVEPnReaH04wBJVFi +/rw== X-Gm-Message-State: AOAM531quZJrtR0Pq+Kzwi5fqoaBFcflXHaMkW3iACSdqKHG9KOTXLRG fZIJC93/NSipBX2ouwBwQzbDT/Fyi+cATjBV+MFJS4pm7M9lZA== X-Received: by 2002:a2e:9606:: with SMTP id v6mr16780985ljh.79.1620129132801; Tue, 04 May 2021 04:52:12 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Krishna Chaitanya Date: Tue, 4 May 2021 17:22:01 +0530 Message-ID: Subject: Re: Module versioning + Missing CRC in symvers + export tracepoints To: Linux Kernel Mailing List , mmarek@suse.cz, arnd@arndb.de Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 20, 2021 at 6:26 PM Krishna Chaitanya wrote: > > Hi, > > I am seeing an issue of no CRC being generated in the Module.symvers for a > driver module even when CONFIG_MODVERSIONS Is enabled, this causes > modpost warnings about missing versioning. > > The module in questions only exports tracepoint related symbols (as > struct tracepoint is > part of the module CRC), I have seen this with other modules also e.g. > iwlwifi with CONFIG_MODVERSIONS. > > Though I am trying on 5.12.-rc2, also, seeing this issue with older kernels with > CONFIG_MODVERSIONS enabled e.g. 4.15.0, Below are a couple of snippets > to demonstrate the issue. > > modpost warnings > =============== > > WARNING: modpost: EXPORT symbol "__tracepoint_iwlwifi_dev_ucode_event" > [drivers/net/wireless/intel/iwlwifi//iwlwifi.ko] version generation > failed, symbol will not be versioned. > WARNING: modpost: EXPORT symbol "iwl_remove_notification" > [drivers/net/wireless/intel/iwlwifi//iwlwifi.ko] version generation > failed, symbol will not be versioned. > > > Module.symvers (after modpost) > ============== > 0x00000000 iwl_remove_notification > drivers/net/wireless/intel/iwlwifi//iwlwifi EXPORT_SYMBOL_GPL > 0x00000000 __tracepoint_iwlwifi_dev_ucode_event > drivers/net/wireless/intel/iwlwifi//iwlwifi EXPORT_SYMBOL > > Any ideas? Adding people from this https://patchwork.kernel.org/project/linux-kbuild/patch/CA+55aFxCKgTrh1gS-cMyhBa0QoLW2DL2+DYxOAcA-Bd15H15vg@mail.gmail.com/ thread to throw some light on non-asm version of the issue.