Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp3598394pxy; Tue, 4 May 2021 06:03:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOKrPNvOTYuc6vO3kxyGfdJh0FETM1lZFwI0j2Playj2uzaPzSRQWmcmUPbCFGKWzWNcF8 X-Received: by 2002:a17:907:10cb:: with SMTP id rv11mr21821890ejb.379.1620133409424; Tue, 04 May 2021 06:03:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620133409; cv=none; d=google.com; s=arc-20160816; b=woFFR5RS8AwgxfY3Phzr1hOhWAhqh2emWV3uCINwBhGbiQ5QAVOgR0ieYYU6AOzIDi 751zI/2+boa9mhIVBrO8oiVOrvN5Z8tkArid2nwgx91tSMFPzPkocVIz9l266BC+W4yf 3m+oWwOQaaD60S/b30kTXOZKhg3gr7phGnJb4Abel6Ig18hIC/jau0hz1i2EVSxHSHDP 3cXA2prAxjH3yfZbnIx73T8LV4JNmjHE1Dymd7Yl7ldCvYQ6HbjBsYhi7FbX1jcyvd+6 MiN0wH4AohNP66HG48qtIJ3mABzx0FSGnmvyVv7V448RZooPDx9MvBEqjY372iKJRMyz V0zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=cuuhE2Jzhgc+T4wkPSJAcBH/HTxXSNFKVUUvA9nnkSk=; b=mZWAqM5Y1saN2gX5tTGBVBBsNwQnsE0RW09IH+f27N2ukD5QLEP90ZxUTDD6m6ZDpG bq+L1zeDPqFwtS+8r6sKV4ZWzRebW8Emm5IIi7U+7dp/vYK4f8MW3XPsIn3ELEoHnedW unHYz8vabb/PFwaaUQIGwDXTVoumCknZOeqG13xXGSIcjRMv4LUrbkseLqr71+uPKtt1 xJFFvxHyAGXY3JO3Ajk5UcECq3usaDG0dmsq03zoMGmgRNaGDx2/09IvYrvpkDiuC8nq JmpyPCGYvfbobg+fscZ0XttTKQlGXtw1MTOyZLFiGtFTcx2ZKptXSrAixomXzwYv2F2W OXZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hp22si2665847ejc.174.2021.05.04.06.02.57; Tue, 04 May 2021 06:03:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230496AbhEDNBl (ORCPT + 99 others); Tue, 4 May 2021 09:01:41 -0400 Received: from verein.lst.de ([213.95.11.211]:39378 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230373AbhEDNBl (ORCPT ); Tue, 4 May 2021 09:01:41 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id CA8C368AFE; Tue, 4 May 2021 15:00:39 +0200 (CEST) Date: Tue, 4 May 2021 15:00:39 +0200 From: Christoph Hellwig To: Greg Kroah-Hartman Cc: Greg Kurz , Christoph Hellwig , Michael Ellerman , Alex Williamson , Jason Gunthorpe , kvm@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Paul Mackerras , Daniel Vetter , linux-api@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org Subject: Re: remove the nvlink2 pci_vfio subdriver v2 Message-ID: <20210504130039.GA7711@lst.de> References: <20210326061311.1497642-1-hch@lst.de> <20210504142236.76994047@bahia.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 04, 2021 at 02:59:07PM +0200, Greg Kroah-Hartman wrote: > > Hi Christoph, > > > > FYI, these uapi changes break build of QEMU. > > What uapi changes? > > What exactly breaks? > > Why does QEMU require kernel driver stuff? Looks like it pull in the uapi struct definitions unconditionally instead of having a local copy. We could fix that by just putting them back, but to me this seems like a rather broken configuration in qemu when it pulls in headers from the running/installed kernel without any feature checks before using them.