Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp3619103pxy; Tue, 4 May 2021 06:26:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6+W3mHcdL8zxXcW3Bpo0ZUFWfqzv3thpjm0RqTZ8keoRECEV4reHDouJxA6SlsUIzMgJu X-Received: by 2002:a63:1157:: with SMTP id 23mr23598199pgr.25.1620134813911; Tue, 04 May 2021 06:26:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620134813; cv=none; d=google.com; s=arc-20160816; b=o+n7/633QPeMPAJXE2KC3ZRaWyI1izPpHFJ4fA/pqe4swlmyoTYaGLxXFVwoxY3FrC M6Jd2FmnClHU3/HoR/vmbs42SWtYeHaag//yMEpKCl8h8Ji6V/OaMGuZDn552TnxUr/J fkhxyJDlQAoVZt3Wzeq4A8jZpW4QWfY46wTgGfStvMxDRsKIWDnudkUAF71I5h6MgiQL YG3T7fJN3lxfiLkiJYH7seaSMO+qhoA6VhKozYUvEQOBet2aViKpKKPrMWo4lRkomHUk Jiilc7eQ9TNp0k2aBqc1OSB7SU6zE2B2CvK8UsVkrKaFI2//Efg8oDvxU90FUr0PBnJu FQEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=UkcPfOw1zL7OvDlpQg+xfIeD/O5P0yQ5Qy64lO5GzLE=; b=gifM6N3uKVLfFGiIOLDX8jm6DHMvO5zW8T7WFm7sLokuiaWJSjMCtV6IBlpWGmdDAB qEW8RVE7lklJ2Wbyfi/+uCAjY4F6l0bseJDTGJWvKuLDA0dhXGaGF2jGXH7memNhIM3+ RrOZfxl4NmSaSAFgSX8xk3HSUrJJ2SYbklMvvYjpvZ2edMHkStLmbA3aL8i8qrErc955 DbGJUdPi84n8U+3nzovsjl/sk+COGsVmZJv/XHlhAAJRZEbjpbAHeUXSqh1hDO9bgD4J f7QpJUr47Op/0+UDCjHSqLqKN1bJRyeLcU0K8RwlbvUJ3eEwXB8tOFU1+lKjAbHBK6OC 6qAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XPCII7yg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k136si4503898pgc.155.2021.05.04.06.26.41; Tue, 04 May 2021 06:26:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XPCII7yg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231156AbhEDNYX (ORCPT + 99 others); Tue, 4 May 2021 09:24:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230413AbhEDNYW (ORCPT ); Tue, 4 May 2021 09:24:22 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70B9FC061574; Tue, 4 May 2021 06:23:26 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id j3-20020a05600c4843b02901484662c4ebso1273908wmo.0; Tue, 04 May 2021 06:23:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=UkcPfOw1zL7OvDlpQg+xfIeD/O5P0yQ5Qy64lO5GzLE=; b=XPCII7ygCpVlBB1aHHi7dBrAaN5FLXYlUwmw9fncUPCKLKfSx9crjfvejvPxvSnY2B c02c/GpUPnM4v/JWuqo6oOHhCTa+JgIHQ+EdLetMdrPIefIo74IoEvr2cvvj6efSZCBa OKEVArk8xYxaWJICqo9Tn8mgNwpPfTXC0v7GmqiY9fnF8Rjcyeyp9zb1zq+OObsu0z7U WqyZafWtoxPEQjpup4Qdbvi0OZbwFfQD+lZBgNLRsJIL5MKEASSum3nXn8G7GzoBxapQ tvyiVsT8yD5lvZ6cMS1yGszIXS+vpPhaFu+SC2Pv/F7/jbr69Wr8L7v4/g866ZHdfHdl tDSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UkcPfOw1zL7OvDlpQg+xfIeD/O5P0yQ5Qy64lO5GzLE=; b=p3ROswm8v3gZh7qzLoG0gjwncTDNWR2lrc5eJkZsTNY8i7hnPWKKD6jcXFiMJZvLaN Haof6NmaQA2GTgyJ3iwZysxvZgnJ08OvlISZbMlUy+HK4wC1wCnsWYkXCCNsHcnNo3RH +mfcaBSwMEm0KjfUaFgKkgafHlNNvOsvo3ddSQ9uFeJhinUxiJvmaZ2s465s19C5e4Vx mlC05nx/a+CW3zxZJXBU4oOmUAnL10TNKKxdb1+YV5/gZX3SkCrnHJEUK81ywgY8C3pp 1YOI/u0Kbs/KpUH5tnYfwREE5F+j62eTcOLcM2IeNpgj1uFvQrfltKNbUCBA4+kICtzv P5iA== X-Gm-Message-State: AOAM533uVUKJYVjA8iDLyhxACbWYFWPt8uPrdDsJLFNnAyYIGwnltxId AgRMmemHiFJXX91HQNal8n8= X-Received: by 2002:a7b:c38d:: with SMTP id s13mr3945898wmj.43.1620134605114; Tue, 04 May 2021 06:23:25 -0700 (PDT) Received: from localhost.localdomain ([197.2.237.199]) by smtp.gmail.com with ESMTPSA id f24sm2546301wmb.32.2021.05.04.06.23.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 May 2021 06:23:24 -0700 (PDT) From: Khaled ROMDHANI To: sfrench@samba.org Cc: Khaled ROMDHANI , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH-next] fs/cifs: Fix resource leak Date: Tue, 4 May 2021 14:22:57 +0100 Message-Id: <20210504132257.23632-1-khaledromdhani216@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The -EIO error return path is leaking memory allocated to page. Fix this by invoking the free_dentry_path before the return. Addresses-Coverity: ("Resource leak") Signed-off-by: Khaled ROMDHANI --- fs/cifs/link.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/cifs/link.c b/fs/cifs/link.c index 1cbe7ec73728..1485c6095ba1 100644 --- a/fs/cifs/link.c +++ b/fs/cifs/link.c @@ -686,8 +686,10 @@ cifs_symlink(struct user_namespace *mnt_userns, struct inode *inode, void *page = alloc_dentry_path(); struct inode *newinode = NULL; - if (unlikely(cifs_forced_shutdown(cifs_sb))) + if (unlikely(cifs_forced_shutdown(cifs_sb))) { + free_dentry_path(page); return -EIO; + } xid = get_xid(); -- 2.17.1