Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp3683001pxy; Tue, 4 May 2021 07:45:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkGbWdNl5ktec8JUHpIHmqiUJMbbjKUUDTLZE8JBbAK+5W9SIWXgfxOGe1CJEeMo0pGqjm X-Received: by 2002:aa7:d382:: with SMTP id x2mr25780596edq.60.1620139516919; Tue, 04 May 2021 07:45:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620139516; cv=none; d=google.com; s=arc-20160816; b=C3VTDPV2JleQSlMXNTz0ffrfKOlbyGP0oT0hTDuyAKki+NPdGSc7MQdPGO1OTPxk4k ZB0PcQD3UoKjEuLJ5PpqzQ+PZNLUUJBnNyRcHTkBKOAtCt5Clq9LRqbIN1Ed7eGa2UR1 ZvzWuJs6oaK3rSpOegNCiSex+0yPGguQ/Sh8h9udPFRLMetoTfDxwqvvI9PMcCS5wdas S6mqHPMQsQ7shVncvzjIQtzvzoGY8eD+pZyTNKa1Ibu6mjqWhoyBS66RyEUnvrt28RZi csBCy06JBzlxGKOxGOoAqBsGOI8ZhLA3qaCAe9OLFUqBsGBnPS+gOpGVXbr6oZXf+2kZ BHCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=EjFNFfHQTklfu8IZDxa7KPvYRpD29noNVaVM2H3niUo=; b=mcTLOVStsCpM8sho4Anm92wLmXYx8SRFLDA8vdAO+ojvcQ+28dPKi+7RqddLMA2R81 Xal85Un76dUj0r7j6f0F1V5dXAy/gEneoud4b7/LNkIXeHw/byQzNwhdVIcuWsT+xNmo Ftv2/+FvTvCCX1N6VotIQMzc4aPyqB2Adhi75UjUPkFc9DnEfR9Tpn8etcWQ2X179wCs ttjoCZOsI/JRF68TxHhZAWMhlDaVlOH9y+QDgMlTUWL3sm/spgwe6f24SR6/WtEtbBvz sxnbmcVPKt0C1Hg0v4aOzxNzMWHw0rz+ovr7bJNbcNcvhQffBAVgf/tezEe/X6LwMtWa 9kzA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x11si2676389ejv.267.2021.05.04.07.44.53; Tue, 04 May 2021 07:45:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231670AbhEDOlw convert rfc822-to-8bit (ORCPT + 99 others); Tue, 4 May 2021 10:41:52 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:44448 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231610AbhEDOlo (ORCPT ); Tue, 4 May 2021 10:41:44 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 27BE01C0B9B; Tue, 4 May 2021 16:40:47 +0200 (CEST) Date: Tue, 4 May 2021 16:39:45 +0200 From: Pavel Machek To: Subbaraman Narayanamurthy Cc: Bjorn Andersson , Rob Herring , Andy Gross , Thierry Reding , Uwe Kleine-K??nig , Lee Jones , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Marijn Suijten , Yassine Oudjana , Luca Weiss Subject: Re: [PATCH v7 1/6] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding Message-ID: References: <20210429211517.312792-1-bjorn.andersson@linaro.org> <20210429211517.312792-2-bjorn.andersson@linaro.org> <635d3f2c-d3a8-c0d6-7659-c22e44103901@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <635d3f2c-d3a8-c0d6-7659-c22e44103901@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On Mon 2021-05-03 18:01:09, Subbaraman Narayanamurthy wrote: > On 4/29/21 2:15 PM, Bjorn Andersson wrote: > > This adds the binding document describing the three hardware blocks > > related to the Light Pulse Generator found in a wide range of Qualcomm > > PMICs. > > > > Signed-off-by: Bjorn Andersson ... > > + "^led@[0-9a-f]$": > > + type: object > > + $ref: common.yaml# > > + > > > Just a question more than a comment. From what I can see, when this device is specified as a multi-color device or an individual device (e.g. "red", "green" and "blue"), the user can only set "pattern" and "repeat" under the corresponding device after setting "pattern" to "trigger". Would you be planning to add a way (e.g. another set of DT properties) for the user to specify such patterns via the devicetree itself? > Please trim your replies and format emails to 72 columns or so. If you need patterns in DTS that can be discussed, but it should be generic functionality not tied to one driver. Best regards, Pavel --