Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 4 May 2021 08:24:49 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     David Laight <David.Laight@ACULAB.COM>
Cc:     Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        David Kaplan <David.Kaplan@amd.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Kees Cook <keescook@chromium.org>, Jann Horn <jannh@google.com>
Subject: Re: Do we need to do anything about "dead =?utf-8?B?wrVvcHM/Ig==?=
Message-ID: <20210504132449.wmvxtubhuzuqc3xr@treble>
References: <CALCETrXRvhqw0fibE6qom3sDJ+nOa_aEJQeuAjPofh=8h1Cujg@mail.gmail.com>
 <20210503233010.x5lzpw4dq3gueg47@treble>
 <CALCETrVwFrpZU-6C=AVurVPk4ahV2yjqyhFeYbL_0OtBNJnZ=w@mail.gmail.com>
 <20210504031616.covixup7rhdil3yq@treble>
 <5937e5a2f1014e2da4a07e249745ceb1@AcuMS.aculab.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <5937e5a2f1014e2da4a07e249745ceb1@AcuMS.aculab.com>
Precedence: bulk

On Tue, May 04, 2021 at 01:06:06PM +0000, David Laight wrote:
> From: Josh Poimboeuf
> > Sent: 04 May 2021 04:16
> ...
> > I was actually thinking more along the lines of
> > 
> > 	val = 0;
> > 
> > 	if (user_supplied_idx < ARRAY_SIZE) // trained to speculatively be 'true'
> > 		val = boring_non_secret_array[user_supplied_idx];
> > 
> > 	if (val & 1)
> > 		do_something();
> > 
> > In other words, the victim code wouldn't be accessing the secret
> > intentionally.  So there's no reason for it to avoid doing
> > data-dependent branches.
> 
> Isn't that one of the very boring standard spectre cases?

Classic v1 as described in the Spectre paper was a data-dependent
load/store, not a data-dependent branch.

-- 
Josh