Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp3807419pxy; Tue, 4 May 2021 10:19:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjDovc/hfZ31Vo4bmKhnu8BjtHIDluWI+/4ZPdy54A5EZG68TCL5oKoj5VCRemo26/ySL3 X-Received: by 2002:a65:480a:: with SMTP id h10mr23914847pgs.63.1620148747948; Tue, 04 May 2021 10:19:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620148747; cv=none; d=google.com; s=arc-20160816; b=WKFuM+w34ZfQxu7oU6GWWK6ozma2HCvhA2kwSC64XJlcSyG2JLBVbjW+X7EvwjmlPo ISOxl95q4ECjUVGCk3fCUkr60X5mE2VHjlpvk9xes1hybaXWpRitWE3EA7RYgWSsFoU8 DT3ZCe29mCjGOp3w9D6zw6GNdzEF+MnDhDS02eSybXBgS+aUqhOQZsMirrqkPXC/8pYU BskQOAYIiWspdXstwgWgiKjXMjBP9zPNvS2mGXUwqOxB+qn5NUtwtl4eB2d3Ilr9bTni 5SkImvjC1699FcJrvsBaKEJpLJEYdYv+IvMGcmvJQp/Jx/5YUfKRsR+z4W7A5mqex9jJ zfwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=CcLDDpeab0siUfyKp6m1oFLtaB82UOnNEJ7dk02MEic=; b=mLknqaEu9SnABjJ32GDtd7scCOwLY+tNwS6LsOzT6q3x9dUKYz+ZYfkMKvoeyqafTZ Im0kmeCyt0mw0SVC6JFBgcZHxP2LF0AHwZiWUF3m9IkXcqqIQrAaDHrMNgOsfmlXPhgc t2Ux9xOYWNLkKUdwz2iXCI14/VXIoFYNIuau8jCuy1GPjNQfPQgatVmADazqeUm848s4 k09KIMWz4QqjN6QfGqEq9XAL8nbOcHWeWFgjAm3ltL9UGxVgMyABhf+XfKw7Xzo200St xEN6nBQgRi55jVbg9iAXDXLHRgGmOijb1963v0p6I5OkSTXkGt/YyU9GLcfhFlnCc6q8 P/RQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@quicinc.com header.s=qcdkim header.b=DHkGt4ZX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f7si7302304pjp.156.2021.05.04.10.18.54; Tue, 04 May 2021 10:19:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@quicinc.com header.s=qcdkim header.b=DHkGt4ZX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231959AbhEDRRS (ORCPT + 99 others); Tue, 4 May 2021 13:17:18 -0400 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:20267 "EHLO alexa-out-sd-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231758AbhEDRRR (ORCPT ); Tue, 4 May 2021 13:17:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1620148582; x=1651684582; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=OkFz34xGip9rSgKNkrxBDPhE2MkMQfstZMZUHWZA9HA=; b=DHkGt4ZXWBfNZahUJMSd9SZtATc7dXsuAzqTvpBNeeCBtMdjQ5IhbCpu yZPR1vHGy+ko7/IRLpT094+kZZySrYqZ9JrFkl/wdfKSlmFoFRuwhijO/ 1wVFAcwCQMlAKQOA88UY6nFyMxwC99ekpA/PWcwlKYcowDkhfWqyM1RWk I=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-02.qualcomm.com with ESMTP; 04 May 2021 10:16:22 -0700 X-QCInternal: smtphost Received: from nasanexm03e.na.qualcomm.com ([10.85.0.48]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/AES256-SHA; 04 May 2021 10:16:21 -0700 Received: from [10.226.59.216] (10.80.80.8) by nasanexm03e.na.qualcomm.com (10.85.0.48) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 4 May 2021 10:16:19 -0700 Subject: Re: [PATCH v2] bus: mhi: core: Improve debug messages for power up To: Bhaumik Bhatt , CC: , , , References: <1620072038-36160-1-git-send-email-bbhatt@codeaurora.org> From: Jeffrey Hugo Message-ID: Date: Tue, 4 May 2021 11:16:18 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <1620072038-36160-1-git-send-email-bbhatt@codeaurora.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanexm03d.na.qualcomm.com (10.85.0.91) To nasanexm03e.na.qualcomm.com (10.85.0.48) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/3/2021 2:00 PM, Bhaumik Bhatt wrote: > Improve error message to be more descriptive if a failure occurs > with an invalid power up execution environment. Additionally, add > a debug log to print the execution environment and MHI state > before a power up is attempted to confirm if the device is in an > expected state. This helps clarify reasons for power up failures > such as the device being found in a PBL or Emergency Download > Mode execution environment and the host expected a full power up > with Pass-Through and no image loading involved. > > Signed-off-by: Bhaumik Bhatt Reviewed-by: Jeffrey Hugo