Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp3826920pxy; Tue, 4 May 2021 10:46:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwd6sgYpVltkInm084eAYN3XInzR8scEsgHmHOLkLeC8mH0XqETzVnVKhfhcJElhl00acNN X-Received: by 2002:a62:7a0d:0:b029:28e:b056:ae4 with SMTP id v13-20020a627a0d0000b029028eb0560ae4mr8374891pfc.5.1620150417300; Tue, 04 May 2021 10:46:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620150417; cv=none; d=google.com; s=arc-20160816; b=fE2YrUfFBVEBvqwCjNc5hRV1kZSl2+7CG1w3OpuMOc5HsJeN7Jxh6OKlJJJaQAGVKR CO2Dzmo/uCaSgGKGpnihkqyxl7/+/0WpsbBU+pSnkkPJXNO+kvB9fbonoIJNXRLjRc7h +xb6hgaOXS5qKpBEGDO1uGPO3MMF4t6D5hosukj5MB/zQfs0HX+ses/x0v66ZqibTGqP rYxGIdb5KvRSs34LiFXsPJNUq1LFO4bmxO/Z3RsMdSQg1eD0538hB1fg+hg+SkgeJ/ME tidkOSZHylj/DL3PqA1IhctccEvDitR3rkYEwUDARhaFdz1R8uULOWOyFoWEW5R4q79W Sinw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=6NAcSn2rrwImkZkJu1Td7CX7cpZZIOQv7nB+s1Fm27o=; b=XwhMskBMuzISGfj9DfrWd8iiBaVRr5HICb5RkDiNjeGwhPJodi/Im2DzdAmWbq1Ama kk8HHg/YToIvCFBFm6THYY/hIqw+QvDkxH6vr5poiWm5o5U3jc+yghkNEv3I1fODQkOV Pnb/gJIGnmU6QubFFjX2W8Mo04NnCi+OyaXObOtjz9GEdf5V+KB1DiuysJEuiuXg28RL Tpf/BKfxWyPACO8O77GLYH6iA2QghHIr486PF8xxN8nxgTVmhpLWenan5nhg18xO8Sjw FGkhLu/dHpY78kmxTpmQEOdZdbie0s/cBb1WfY6j2P0eMwUv+wpusUDDgy1OAvW6z9eb +D4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@quicinc.com header.s=qcdkim header.b=MdJYqpq3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 84si17477966pfu.307.2021.05.04.10.46.43; Tue, 04 May 2021 10:46:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@quicinc.com header.s=qcdkim header.b=MdJYqpq3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231777AbhEDRou (ORCPT + 99 others); Tue, 4 May 2021 13:44:50 -0400 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]:55953 "EHLO alexa-out-sd-01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230331AbhEDRot (ORCPT ); Tue, 4 May 2021 13:44:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1620150234; x=1651686234; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=U3GLipCjgI2eLHosYx9PUnpP0j7sShIr3djY0YdLDcI=; b=MdJYqpq3H/OTeoQ1ScKPmjlDHQhDw6GrTvsQKiWmeOIR/N13eMw8K0dR +I8wx1K4EILg1mVYw4WHhNZSXeli49olCtfqBusOSQ/Pm63FmBOBS2flS IauqTsYgRd9Z1vWC5uYOfhDBcdGNvorSekj6QbI0g/lvVMhgqtRg0qdZh Y=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-01.qualcomm.com with ESMTP; 04 May 2021 10:43:54 -0700 X-QCInternal: smtphost Received: from nasanexm03e.na.qualcomm.com ([10.85.0.48]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/AES256-SHA; 04 May 2021 10:43:54 -0700 Received: from [10.226.59.216] (10.80.80.8) by nasanexm03e.na.qualcomm.com (10.85.0.48) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 4 May 2021 10:43:53 -0700 Subject: Re: [PATCH v8 3/9] bus: mhi: core: Improvements to the channel handling state machine To: Bhaumik Bhatt , CC: , , , , , References: <1617311778-1254-1-git-send-email-bbhatt@codeaurora.org> <1617311778-1254-4-git-send-email-bbhatt@codeaurora.org> From: Jeffrey Hugo Message-ID: <770e6e03-905f-887a-2f32-19a2eb9e3cbd@quicinc.com> Date: Tue, 4 May 2021 11:43:52 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <1617311778-1254-4-git-send-email-bbhatt@codeaurora.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanexm03d.na.qualcomm.com (10.85.0.91) To nasanexm03e.na.qualcomm.com (10.85.0.48) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/1/2021 3:16 PM, Bhaumik Bhatt wrote: > Improve the channel handling state machine such that all commands > go through a common function and a validation process to ensure > that the state machine is not violated in any way and adheres to > the MHI specification. Using this common function allows MHI to > eliminate some unnecessary debug messages and code duplication. > > Signed-off-by: Bhaumik Bhatt > --- Reviewed-by: Jeffrey Hugo