Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp3855704pxy; Tue, 4 May 2021 11:24:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/Zd7Vki1Y8+nYz0JIi0zN7s2qKieJuZt8cwV2f8EtVM/g9FEcUYFJcFRefkdjP7+x3B+L X-Received: by 2002:a17:90a:fed:: with SMTP id 100mr6302919pjz.89.1620152676361; Tue, 04 May 2021 11:24:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620152676; cv=none; d=google.com; s=arc-20160816; b=zPAbA6O1YkgAA3kzSqt8d0oWks0+KQc2ZwR3CmVT0PwFWQvi7W6/8uqQehWzpqLE/r XFoEzp4E9szrxvddSUCmGcEQMBpKdGXaappUto5Y2h4yUAfuRE+X8XPDw97cGAH+CVt3 cc0M/5PpssjO2LEutQnIDrBa0s+5oXJ1dwH9as9HT66e02IzTiE+i5xATaWUFu4eikqA c75Ki10UwZspiAxj2dtYgwfN/ch1o5INliJY4SxXCaTRd6D5ksUud/IGkdWeIa7NgjJ8 YV2Ete7fsQIbIUhWnQJicXC/yWf5FDnWNpfEMDYeA/qQzmScn/jYoApvRj4HlDeYzj9m shCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=GVIxTT9uSFfUO3j3YO7sGQ1PTKDOjdIH+lYA0YgyIyA=; b=pUZ8OPqOqgdNFaUcZSpDZbClQuBgrLoBfAinQlKprJt5c76hBwsvKwhyyg087sAKPN 7U0TNkCvIeWk9IaPBv5oOj8UbOXtDLYIpxCnzZIfX6x2ZqAwRCKG2KIE10a78kYtslmJ pDXvHspItqUwbEqSyUugBLmkIDesNDJtYRrbVobZu8hE4Xfgk27Ke/QiWc5AEgId6shP iLIOEgdnHlHsWjtIQTyOopPoxPnSSjeP3y0SwzCqW4D/ovhXo11Q1OV0VK/JgobIcwMn ZsDa0MXAZgV3t73e9GC/SoCjEticIK2owrGhKWQTwUyKFz0ktweLps5NSkCvFqxyXDYh MNLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dycdF2qf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q16si4689311plx.427.2021.05.04.11.24.15; Tue, 04 May 2021 11:24:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dycdF2qf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231669AbhEDQHq (ORCPT + 99 others); Tue, 4 May 2021 12:07:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27045 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231274AbhEDQHn (ORCPT ); Tue, 4 May 2021 12:07:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620144408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GVIxTT9uSFfUO3j3YO7sGQ1PTKDOjdIH+lYA0YgyIyA=; b=dycdF2qfxM8IDOjcyT5dLckHXobifrVzvi1XMcrJcXoY7l33XxFth5lB/vlpctVH8cqZ9D fwtoH6Br8bf6dPnOOOOowwYpuxq2AyCETLBFJSL6Tabwguygo7XVz+60soI/L7CnceH9uG QjbhscPjEyklitlvQ07trZQmahML5R4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-78-I7M62cUEMh-U8VfpQ2FvKw-1; Tue, 04 May 2021 12:06:46 -0400 X-MC-Unique: I7M62cUEMh-U8VfpQ2FvKw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BF23E107ACCA; Tue, 4 May 2021 16:06:44 +0000 (UTC) Received: from gondolin.fritz.box (ovpn-113-126.ams2.redhat.com [10.36.113.126]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C81219C71; Tue, 4 May 2021 16:06:39 +0000 (UTC) Date: Tue, 4 May 2021 18:06:36 +0200 From: Cornelia Huck To: Alex Williamson Cc: kvm@vger.kernel.org, groug@kaod.org, hch@lst.de, gregkh@linuxfoundation.org, daniel@ffwll.ch, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, qemu-devel@nongnu.org, linuxppc-dev@lists.ozlabs.org, qemu-ppc@nongnu.org Subject: Re: [PATCH] vfio/pci: Revert nvlink removal uAPI breakage Message-ID: <20210504180636.6251eaf1.cohuck@redhat.com> In-Reply-To: <162014341432.3807030.11054087109120670135.stgit@omen> References: <162014341432.3807030.11054087109120670135.stgit@omen> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 04 May 2021 09:52:02 -0600 Alex Williamson wrote: > Revert the uAPI changes from the below commit with notice that these > regions and capabilities are no longer provided. > > Fixes: b392a1989170 ("vfio/pci: remove vfio_pci_nvlink2") > Reported-by: Greg Kurz > Signed-off-by: Alex Williamson > --- > > Greg (Kurz), please double check this resolves the issue. Thanks! > > include/uapi/linux/vfio.h | 46 +++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 42 insertions(+), 4 deletions(-) I had already hacked up a QEMU patch that moved the definitions into local headers, but this one is less of a hassle. (Code compiles fine after doing a headers update.) Reviewed-by: Cornelia Huck