Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 2/2] KVM: X86: Introduce KVM_HC_PAGE_ENC_STATUS
 hypercall
To:     Sean Christopherson <seanjc@google.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        srutherford@google.com, joro@8bytes.org, brijesh.singh@amd.com,
        thomas.lendacky@amd.com, ashish.kalra@amd.com,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@suse.de>,
        x86@kernel.org
References: <20210429104707.203055-1-pbonzini@redhat.com>
 <20210429104707.203055-3-pbonzini@redhat.com> <YIxkTZsblAzUzsf7@google.com>
 <c4bf8a05-ec0d-9723-bb64-444fe1f088b5@redhat.com>
 <YJF/3d+VBfJKqXV4@google.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <f7300393-6527-005f-d824-eed5f7f2f8a8@redhat.com>
Date:   Tue, 4 May 2021 22:27:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <YJF/3d+VBfJKqXV4@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 04/05/21 19:09, Sean Christopherson wrote:
> On Sat, May 01, 2021, Paolo Bonzini wrote:
>> - make it completely independent from migration, i.e. it's just a facet of
>> MSR_KVM_PAGE_ENC_STATUS saying whether the bitmap is up-to-date.  It would
>> use CPUID bit as the encryption status bitmap and have no code at all in KVM
>> (userspace needs to set up the filter and implement everything).
> 
> If the bit is purely a "page encryption status is up-to-date", what about
> overloading KVM_HC_PAGE_ENC_STATUS to handle that status update as well?   That
> would eliminate my biggest complaint about having what is effectively a single
> paravirt feature split into two separate, but intertwined chunks of ABI.

It's true that they are intertwined, but I dislike not having a way to 
read the current state.

Paolo

> 
> #define KVM_HC_PAGE_ENC_UPDATE		12
> 
> #define KVM_HC_PAGE_ENC_REGION_UPDATE	0 /* encrypted vs. plain text */
> #define KVM_HC_PAGE_ENC_STATUS_UPDATE	1 /* up-to-date vs. stale */
> 
> 		ret = -KVM_ENOSYS;
> 		if (!vcpu->kvm->arch.hypercall_exit_enabled)
> 		        break;
> 
> 		ret = -EINVAL;
> 		if (a0 == KVM_HC_PAGE_ENC_REGION_UPDATE) {
> 			u64 gpa = a1, npages = a2;
> 
> 			if (!PAGE_ALIGNED(gpa) || !npages ||
> 			    gpa_to_gfn(gpa) + npages <= gpa_to_gfn(gpa))
> 				break;
> 		} else if (a0 != KVM_HC_PAGE_ENC_STATUS_UPDATE) {
> 			break;
> 		}
> 
> 		vcpu->run->exit_reason        = KVM_EXIT_HYPERCALL;
> 		vcpu->run->hypercall.nr       = KVM_HC_PAGE_ENC_STATUS;
> 		vcpu->run->hypercall.args[0]  = a0;
> 		vcpu->run->hypercall.args[1]  = a1;
> 		vcpu->run->hypercall.args[2]  = a2;
> 		vcpu->run->hypercall.args[3]  = a3;
> 		vcpu->run->hypercall.longmode = op_64_bit;
> 		vcpu->arch.complete_userspace_io = complete_hypercall_exit;
> 		return 0;
>