Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp115416pxy; Tue, 4 May 2021 20:19:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3Qv4vN13wPdIHGj3kpckHAY0YeQBPjxPcY75iUx6brfZBKs5YuyLqt8VBDCdf0oHubxkv X-Received: by 2002:a63:2686:: with SMTP id m128mr26621428pgm.406.1620184743664; Tue, 04 May 2021 20:19:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620184743; cv=none; d=google.com; s=arc-20160816; b=ohMB+cv/DvVjSv0vsYXM/VqmlifFSDKOoC2Sn9mphICEUZyFjfhKMd3ZusRDSVIgKB lwilocrPsK39KLx1HDfvEiRxVfi0p2RRxZD0LRrzg4L7lD80LTPhlB7ZNwzd4kRa3CZT vSRHHutzxA9hNgohz+JxM7zy+Z5J234r4Nyzkgb65igUEayBv24vnRwSGfumIRU7ilxY Q72xUK2Rr2YQErDhN/Bivos+2qC8WPujI5CLQ1Hds0aw69XmbLK1JGki10YxQALVSvbL 0j+nBUhXY0ewJsyDqDbIbpVHvUrRxmZzgJvCxSX/myfwKOmcvr3REg3rH7lLcfS5WPU9 BLhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:ironport-sdr :ironport-sdr; bh=Mzzl2g3k/gCIZ7L1He2LYcDpzDBIWKsZ2o7dCbplq7M=; b=xCxwr9xKL1+m12X64Jd5+baADbCWhJgbIY8nTCvCLZjpbHqESPiw1rY3AAiUrsLELg ywCGgLbsR6AtOCmCd228ErWjM9Zju0s6RMfJk6Nu9Mam7Wjc/gDpijS+p8FJ0j2dVDuO ewq0gqrZzLttWCeslRbFSNwXHnCloZTc4W7cm8wHwd50nR+9z/39OZLxifhsIV3nfLZh MLmTcj/95gkrLI6y99dGngKbvSiWM1ZIbzS+ECNuQ+lQyOlonJ/UM+dJ5UJszHoEElvF ABxtRx2wqVS2NF1MZUqvcDZfXT5/B43jvs4e8NhhBST+SEnG+Osk6a4xckb+LQc6CUR/ KHfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gc1si1663495pjb.111.2021.05.04.20.18.50; Tue, 04 May 2021 20:19:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231253AbhEEDFt (ORCPT + 99 others); Tue, 4 May 2021 23:05:49 -0400 Received: from mga03.intel.com ([134.134.136.65]:26123 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230079AbhEEDFt (ORCPT ); Tue, 4 May 2021 23:05:49 -0400 IronPort-SDR: aWySfpvG6YLLVAOPfCQC2Pf6pX/7p2vLGkStJsrZPxvz5PJxx1YMYHICiLpzZfLlvV4Mi7PZjj lEflBLfhC4Ow== X-IronPort-AV: E=McAfee;i="6200,9189,9974"; a="198179093" X-IronPort-AV: E=Sophos;i="5.82,273,1613462400"; d="scan'208";a="198179093" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 20:04:53 -0700 IronPort-SDR: eSdL5a60wFebfgQRagO5d8RWIzv8Vwnad4eB1atg/rDzdRg3G5MIDQFf3xiAQ65knE8yIPg0le uc/W7OXpbZ9A== X-IronPort-AV: E=Sophos;i="5.82,273,1613462400"; d="scan'208";a="433593330" Received: from chenyu-desktop.sh.intel.com (HELO chenyu-desktop) ([10.239.158.173]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 20:04:51 -0700 Date: Wed, 5 May 2021 11:09:32 +0800 From: Chen Yu To: Len Brown Cc: "Rafael J. Wysocki" , Zhang Rui , Linux PM list , Linux Kernel Mailing List Subject: Re: [PATCH][RFC] tools/power turbostat: Fix ACPI CState format issue Message-ID: <20210505030932.GA116899@chenyu-desktop> References: <20201012100205.2750-1-yu.c.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 04, 2021 at 06:56:00PM -0400, Len Brown wrote: > On Mon, Oct 12, 2020 at 6:00 AM Chen Yu wrote: > > > > Currently if the system boots with BIOS _CST Cstate information > > enabled, the turbostat output would have unaligned problems: > > > > C1_ACPI C2_ACPI C3_ACPI POLL% C1_ACPI% C2_ACPI% C3_ACPI% CPU%c1 > > 5 37 138 0.00 0.02 1.30 98.51 0.38 0.00 0.00 99.43 > > > > The C1_ACPI% is of 8 bytes, so extend the format accordingly if the field name > > equals to/longer than 8 bytes. > > > > After the patch applied: > > > > C1_ACPI C2_ACPI C3_ACPI POLL% C1_ACPI% C2_ACPI% C3_ACPI% CPU%c1 > > 2 42 96 0.00 0.12 2.60 97.09 0.60 > > Let's shorten the header fields so that a single tab continues to work. > this is helpful for processing turbostat output in .TSV format. > Okay. BTW it looks like the following patch has already fixed the _CST format issue and single tab still works: commit fecb3bc839df64761cc63c9ee9b45c1cad36aee8 Author: David Arcari Date: Mon Aug 10 10:43:30 2020 -0400 tools/power turbostat: Fix output formatting for ACPI CST enumeration thanks, Chenyu