Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp172524pxy; Tue, 4 May 2021 22:24:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTQvqXFE39OUGeue/KtX8cnVji+89sd4TqdLSbEA/dF/X7E0ntDOEGtCNEAhtMBOJ0ClQG X-Received: by 2002:a17:906:9444:: with SMTP id z4mr25620522ejx.330.1620192254570; Tue, 04 May 2021 22:24:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620192254; cv=none; d=google.com; s=arc-20160816; b=xk3PwHotbr5luJQh6YAi28S3zZiftDCNHEfHK9YDC/P1LYOAlTfcukwr8ElFOAuaYk gkMsGi7I9WqohxQN5hDIZZBBSdJ3BwFX83t2F8JGb/PJw9fBdRK1dO4mXfTPbjmxt29y RLRzpdvq1XlvHhWa6k1LQG3PT64lTWVLtqwBQjbKuH1r+901cgCLa87Gx2OSe/VPfuHR p9dbvFQ3i6478C9TaHnlP0NBm/1LjZAUtFuGRY5xEcw0Pkonxnw0T0RcGNaWOsd+5Bxc c/K2bu4sNoTStzIcZ72nOd5rDpHWlhCQy0TbYABTkMxAN9OH8HJd51h9g5g/9Zvq6YCO LftQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=J1Xet39phn3abbfokvhU+x19msP0kdY6jRNZihDGKLI=; b=0mWVGpxZLp+a7LyuJ17RS7LN6aAxfeUltVxIlnpg67D7MmV5rv/EvVEhoA5E5Jf/0u TDcezkJ+rNjmu8fGJ/9UXOS3Ubj25tU4UmT4l+77ki6gimIt85RsxLLz6GQcoHGeWgUd v6F0VYwDiTIH7YEBKNxwSIFvC7g+qAJ+onTKTJTzmQ9tdpyRWo0JWevfRfusK1H6Enqg zd6J1pRUt+GMa4r72HKh2smFWGbvzlP9zc+pcnb0+uP+hG+xAPmdeNX1VKiFy1kfTNlx Z+Od/SITpxRNoV78eIabzN9rvgTjfWxRdf08F5TRWJfXX7U1mGIN79m81OKQtWgosu0p uxNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x18si4323358eji.715.2021.05.04.22.23.51; Tue, 04 May 2021 22:24:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231219AbhEEFVE (ORCPT + 99 others); Wed, 5 May 2021 01:21:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231265AbhEEFVD (ORCPT ); Wed, 5 May 2021 01:21:03 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5EF7C061574 for ; Tue, 4 May 2021 22:20:07 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1le9x1-0004xm-Cn; Wed, 05 May 2021 07:19:59 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1le9x0-0003zj-Vw; Wed, 05 May 2021 07:19:58 +0200 Date: Wed, 5 May 2021 07:19:58 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Bjorn Andersson Cc: Pavel Machek , Dan Murphy , Rob Herring , Andy Gross , Thierry Reding , Lee Jones , Martin Botka , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH v6 2/4] leds: Add driver for Qualcomm LPG Message-ID: <20210505051958.e5lvwfxuo2skdu2q@pengutronix.de> References: <20201021201224.3430546-1-bjorn.andersson@linaro.org> <20201021201224.3430546-3-bjorn.andersson@linaro.org> <20210505051534.id36dvocqfqg3jqc@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yysvbptvjenjm4no" Content-Disposition: inline In-Reply-To: <20210505051534.id36dvocqfqg3jqc@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yysvbptvjenjm4no Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello again, another feedback that only came to me after hitting "Send": It might be sensible to split the patch. In the first part add the LED stuff and in the second the PWM stuff. It would also be good if the PWM code could live in drivers/pwm. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --yysvbptvjenjm4no Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmCSKvsACgkQwfwUeK3K 7AnQ6Af8CwOE61uTM3weEDjryyHoZKRK644ASB7dOVPgJftKvZPzv+DS5L1l403C mKRbcoRqXZB/HfBxjQHH1H+0utzVxcSszp8Z0mmVJ9EgOg3THU9stnOkyKgV9Lqs yfZgrWu0/78gOK506cUgmRd3L2zSV/+0Zm8TaGRmXnqn7BmpV+WxW7QWKwGptJAA //ZrUDMOeJ9+MY/2O+Zgd5i4lLCAnkmb/sly4nAIItvDL8iDeMFLY36ZG186Of/3 tsaueeml3rlY3XYR5a859wqgrNyxxPBx1kXnEv+a6zc+0sBFS+dL+5RPNAavKnsL f3hZZZ9i6pcwk45xjLMnQdsSC2VSFQ== =AFmy -----END PGP SIGNATURE----- --yysvbptvjenjm4no--