Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <5057c53afb568fa70234de2f23b0ffeff75af426.1618421014.git.Rijo-john.Thomas@amd.com>
 <5072c20c-7912-4307-6e04-caa1fe54bf1a@amd.com> <20210503114734.GI21598@kadam> <01387b92-263c-edf1-52bf-b2244ebbd311@amd.com>
In-Reply-To: <01387b92-263c-edf1-52bf-b2244ebbd311@amd.com>
From:   Jens Wiklander <jens.wiklander@linaro.org>
Date:   Wed, 5 May 2021 13:09:17 +0200
Message-ID: <CAHUa44HSaFYHUNEJ9S13czP5EZd2NdpWqaQN6zXaAn0ekt88Ag@mail.gmail.com>
Subject: Re: [PATCH v3] tee: amdtee: unload TA only when its refcount becomes 0
To:     Rijo Thomas <Rijo-john.Thomas@amd.com>
Cc:     Dan Carpenter <dan.carpenter@oracle.com>,
        Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
        Mythri Pandeshwara krishna <mythri.pandeshwarakrishna@amd.com>,
        OP-TEE TrustedFirmware <op-tee@lists.trustedfirmware.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 4, 2021 at 6:26 AM Rijo Thomas <Rijo-john.Thomas@amd.com> wrote:
>
>
>
> On 03/05/21 5:17 pm, Dan Carpenter wrote:
> > On Mon, May 03, 2021 at 09:04:35AM +0530, Rijo Thomas wrote:
> >>
> >>
> >> On 14/04/21 11:08 pm, Rijo Thomas wrote:
> >>> Same Trusted Application (TA) can be loaded in multiple TEE contexts.
> >>>
> >>> If it is a single instance TA, the TA should not get unloaded from AMD
> >>> Secure Processor, while it is still in use in another TEE context.
> >>>
> >>> Therefore reference count TA and unload it when the count becomes zero.
> >>>
> >>> Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
> >>> Reviewed-by: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>
> >>> Signed-off-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
> >>
> >> Hi Dan,
> >>
> >> Can you please give an Ack if you are okay with this patch.
> >> I have incorporated your review comments for v2.
> >>
> >
> > Oh, Sorry.  Thanks!
> >
> > Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thanks Dan!
>
> Jens, can you please pull in this patch.

Done!

Cheers,
Jens