Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp400628pxy; Wed, 5 May 2021 05:09:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytX8vDp3uPJqqe7f8+fwNVxslokG4LapnFNR+WqzQwGeeYNsC3YkMUHY2sFjE4Ixs4ODLM X-Received: by 2002:a63:4652:: with SMTP id v18mr28640812pgk.386.1620216553685; Wed, 05 May 2021 05:09:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620216553; cv=none; d=google.com; s=arc-20160816; b=j/F7EdD6QGguuLfLPYrXHSFaQnageY+SSPGAPWHDM9lCS9+QiR0iUVhUmJgpFXyrZ8 L7i73x+PyPep2Pa23DH2KiukUCK8+/1B7q/AsXAcgMD8yX9uybW2ZgAhiF91bcL6kWic 3+psRS7taedDkQCoOjxkk0x737p+L338ejGd8z206SdGqauUsfFO6u+ck0QJAorD7Uct Bp0zCLt+WjGY3mNkg/KNR44JvxiSaA5d0ai1igWwZyuO6DdPP/Sgztu01pMsj9lrjRza cvT2crOq6Mml4V5MprNUFumc/Vmavx36ZKmHiwLLAsVZmZCsT0qCF3cF9Wmr5DuP4kqd uzdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ussI7br9x1AJnaq08ReXB1yZQBawXKJlWsuw190JMuQ=; b=0/OSpX6nqgSTo0hbBl3a3ajxaTV4uD4XzjD/o4tfIUQ5LRHKDFlmb0WxVeMWhDTKHq aEhCe0kaN39HtsIAVsiPWXPB30aGnJgOe1SsRkcuFTFyduVVPDBZr/8V3RxC+hrk3iWM hiImajFVZyNCjiFkY3wu6qSmRkIe3RXmcL0lFhqBiQweXda5Cl+U4GtZ3ofW6TC9leQC +ojAGYaENaHQhqByD2QDTEfLPpcTGXXTP/Q8/RxCjuOy//NOho18MN8iMyKgnaBQUjoe hhKTkfODnxhlRI1JSFJDARfDQpN25aigbWxG9JVWI3wbniaKA2V2RZlNjnqona+aniOg mClw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BpaFOLPf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k18si7188937pll.324.2021.05.05.05.09.00; Wed, 05 May 2021 05:09:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BpaFOLPf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233019AbhEEMHx (ORCPT + 99 others); Wed, 5 May 2021 08:07:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:47574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233464AbhEEMHU (ORCPT ); Wed, 5 May 2021 08:07:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B2BCF61182; Wed, 5 May 2021 12:06:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620216383; bh=88erwUqYtKf+YqgUa1Oolflux3EyE/1p4VgT11h9OkA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BpaFOLPfai+0I3SqN68fYcldwGl6fNZxFmL1epdmefZCdkAECkspW8yFEYdMdoyLi z4un7R6z1JAQYS75E59/qeDSApKelzHEd6ypFwW+S7dJ8cmFA/Zf+aQ1z/LDzD37w+ FPFHovwMCqt8A9msIIjpFVkDsOCoOsZDb04LcdMg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christoph Hellwig , Jianxiong Gao , Konrad Rzeszutek Wilk Subject: [PATCH 5.10 13/29] swiotlb: add a IO_TLB_SIZE define Date: Wed, 5 May 2021 14:05:16 +0200 Message-Id: <20210505112326.635285720@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210505112326.195493232@linuxfoundation.org> References: <20210505112326.195493232@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jianxiong Gao commit: b5d7ccb7aac3895c2138fe0980a109116ce15eff Add a new IO_TLB_SIZE define instead open coding it using IO_TLB_SHIFT all over. Signed-off-by: Christoph Hellwig Acked-by: Jianxiong Gao Tested-by: Jianxiong Gao Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Jianxiong Gao Signed-off-by: Greg Kroah-Hartman --- include/linux/swiotlb.h | 1 + kernel/dma/swiotlb.c | 12 ++++++------ 2 files changed, 7 insertions(+), 6 deletions(-) --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -29,6 +29,7 @@ enum swiotlb_force { * controllable. */ #define IO_TLB_SHIFT 11 +#define IO_TLB_SIZE (1 << IO_TLB_SHIFT) extern void swiotlb_init(int verbose); int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose); --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -475,20 +475,20 @@ phys_addr_t swiotlb_tbl_map_single(struc tbl_dma_addr &= mask; - offset_slots = ALIGN(tbl_dma_addr, 1 << IO_TLB_SHIFT) >> IO_TLB_SHIFT; + offset_slots = ALIGN(tbl_dma_addr, IO_TLB_SIZE) >> IO_TLB_SHIFT; /* * Carefully handle integer overflow which can occur when mask == ~0UL. */ max_slots = mask + 1 - ? ALIGN(mask + 1, 1 << IO_TLB_SHIFT) >> IO_TLB_SHIFT + ? ALIGN(mask + 1, IO_TLB_SIZE) >> IO_TLB_SHIFT : 1UL << (BITS_PER_LONG - IO_TLB_SHIFT); /* * For mappings greater than or equal to a page, we limit the stride * (and hence alignment) to a page size. */ - nslots = ALIGN(alloc_size, 1 << IO_TLB_SHIFT) >> IO_TLB_SHIFT; + nslots = ALIGN(alloc_size, IO_TLB_SIZE) >> IO_TLB_SHIFT; if (alloc_size >= PAGE_SIZE) stride = (1 << (PAGE_SHIFT - IO_TLB_SHIFT)); else @@ -582,7 +582,7 @@ void swiotlb_tbl_unmap_single(struct dev enum dma_data_direction dir, unsigned long attrs) { unsigned long flags; - int i, count, nslots = ALIGN(alloc_size, 1 << IO_TLB_SHIFT) >> IO_TLB_SHIFT; + int i, count, nslots = ALIGN(alloc_size, IO_TLB_SIZE) >> IO_TLB_SHIFT; int index = (tlb_addr - io_tlb_start) >> IO_TLB_SHIFT; phys_addr_t orig_addr = io_tlb_orig_addr[index]; @@ -633,7 +633,7 @@ void swiotlb_tbl_sync_single(struct devi if (orig_addr == INVALID_PHYS_ADDR) return; - orig_addr += (unsigned long)tlb_addr & ((1 << IO_TLB_SHIFT) - 1); + orig_addr += (unsigned long)tlb_addr & (IO_TLB_SIZE - 1); switch (target) { case SYNC_FOR_CPU: @@ -691,7 +691,7 @@ dma_addr_t swiotlb_map(struct device *de size_t swiotlb_max_mapping_size(struct device *dev) { - return ((size_t)1 << IO_TLB_SHIFT) * IO_TLB_SEGSIZE; + return ((size_t)IO_TLB_SIZE) * IO_TLB_SEGSIZE; } bool is_swiotlb_active(void)