Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp408166pxy; Wed, 5 May 2021 05:19:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGwvLeOyPhe59SOA1JXyNoNpFFR/4nGnQWErZMIQGT3zFP+Otp4OYDQfvD+SEQdJWTFbsX X-Received: by 2002:a17:906:32cb:: with SMTP id k11mr27792063ejk.158.1620217158752; Wed, 05 May 2021 05:19:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620217158; cv=none; d=google.com; s=arc-20160816; b=WAkv+Q4Z8UPZkkf/rtC01ZDU65UVV4GE1LFDbwmMh0mVC2bn7WkcN40Zuw76PLjTRr O5hL9fhkEOB3R/oBvY1XB+gC450exMPyIofg3FWcr3z+++R+SspaT2v9zkWTJbjHE8jG gnzMDZ9iF0xTvYxVD3EsHbF3mkQVcpzhXy+7JmMTL841/EiNLTF9c31jKuqr7shtASQu UW2qmHY691AtOHyVgP+9xw2K7dluByYncSRl+Rhs1ELp5BgYBeufsju5J11Vg7rhKM8I ehWvA5BJUAFbUCKOWhYM2OaUWIP3d7Kxv6ZxBPXjMCGd33enFDKAvxukV8ZJtHtAfUE2 lNEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LLWuOyHUNXd94MsYVd1jXvSaGMn+SxkLIgQRCQ5+eaE=; b=RRU3wzKKqZNtb/CRjzdVhAPaVwneDOJwtZGElnl2Ei+ijVYPeYDW+K1ipmsCYUkYYF hIepMnJDGzTzdEXM5oKlDQHf5uwBMYm3IYPdSKexGonPhlTv8uylgcOz6IUMI1vDbRLB GoOTRtpqmOuYLxBQ9sNE7DSWwB+h9bhxa8K+RPy3nPbv5F1zhAVz0p/g4nVX5Mh74JXa 6layzRd07+2q0L9CN+v7CNdcMQ3XgqWbGkqE/7yC0qSmH6g2cgOXwX6wbRa5/HeEAvuB 9TGQ0M0GsGP1BFJ3b9K3k2cwhratdQ4j8HX5HlG5Robq0hfGjUwWPwPag/Yv4C3kW+cu EMVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tkqYP8jM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f8si2097069edx.424.2021.05.05.05.18.54; Wed, 05 May 2021 05:19:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tkqYP8jM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234099AbhEEMOr (ORCPT + 99 others); Wed, 5 May 2021 08:14:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:50342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233489AbhEEMKh (ORCPT ); Wed, 5 May 2021 08:10:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9A942613F5; Wed, 5 May 2021 12:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620216569; bh=S8RVvjfA1TBf24yMtHk/nvHbnU8yFOYwiTPItBWTCps=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tkqYP8jMw4IrC0vjQXctwpb+vgjnr3OM/WesrrB3CA3Sv8rtFQ8BLF99VoCrVxkNT DFpcP5lWdJvw/uWfH9Xanh/5PwJuy0hixBcZ4+zi72WIUg9MHCJpSOeKI5vEVb7Jm6 ttPOc2S7iUdfXIHaalsQEurnIBn6qDjHZwRB6D/k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jianxiong Gao , Christoph Hellwig , Konrad Rzeszutek Wilk Subject: [PATCH 5.11 21/31] nvme-pci: set min_align_mask Date: Wed, 5 May 2021 14:06:10 +0200 Message-Id: <20210505112327.370017023@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210505112326.672439569@linuxfoundation.org> References: <20210505112326.672439569@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jianxiong Gao commit: 3d2d861eb03e8ee96dc430a54361c900cbe28afd The PRP addressing scheme requires all PRP entries except for the first one to have a zero offset into the NVMe controller pages (which can be different from the Linux PAGE_SIZE). Use the min_align_mask device parameter to ensure that swiotlb does not change the address of the buffer modulo the device page size to ensure that the PRPs won't be malformed. Signed-off-by: Jianxiong Gao Signed-off-by: Christoph Hellwig Tested-by: Jianxiong Gao Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Greg Kroah-Hartman --- drivers/nvme/host/pci.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2629,6 +2629,7 @@ static void nvme_reset_work(struct work_ * Don't limit the IOMMU merged segment size. */ dma_set_max_seg_size(dev->dev, 0xffffffff); + dma_set_min_align_mask(dev->dev, NVME_CTRL_PAGE_SIZE - 1); mutex_unlock(&dev->shutdown_lock);