Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 5 May 2021 14:33:02 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Michael Zaidman <michael.zaidman@gmail.com>
cc:     dan.carpenter@oracle.com, benjamin.tissoires@redhat.com,
        wsa@kernel.org, linux-kernel@vger.kernel.org,
        linux-input@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] HID: ft260: check data size in ft260_smbus_write()
In-Reply-To: <20210413151200.2174-1-michael.zaidman@gmail.com>
Message-ID: <nycvar.YFH.7.76.2105051432470.28378@cbobk.fhfr.pm>
References: <20210413151200.2174-1-michael.zaidman@gmail.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 13 Apr 2021, Michael Zaidman wrote:

> Fixes: 98189a0adfa0 ("HID: ft260: add usb hid to i2c host bridge driver")
> 
> The SMbus block transaction limits the number of bytes transferred to 32,
> but nothing prevents a user from specifying via ioctl a larger data size
> than the ft260 can handle in a single transfer.
> 
> i2cdev_ioctl_smbus()
>    --> i2c_smbus_xfer
>        --> __i2c_smbus_xfer
>            --> ft260_smbus_xfer
>                --> ft260_smbus_write
> 
> This patch adds data size checking in the ft260_smbus_write().
> 
> Signed-off-by: Michael Zaidman <michael.zaidman@gmail.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

I have moved the 'Fixes:' tag to place where it belongs, and applied. 
Thanks,

-- 
Jiri Kosina
SUSE Labs