Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp423022pxy; Wed, 5 May 2021 05:40:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJww6cnhYsUgeZN8J+SUchxtSSsLAa2j6mXONSSm2mZTHXpr199OYzgp/EdHHC/1EPhaoP+J X-Received: by 2002:a63:d47:: with SMTP id 7mr28882101pgn.400.1620218418273; Wed, 05 May 2021 05:40:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620218418; cv=none; d=google.com; s=arc-20160816; b=iztdEd7QFSd5ql1MWCoGTxTFCbdcygowTpgMOuURtOWERcVQOGdZ9esdb/dCGdoJvt hnLPzpncuY7kFmX3jAf7WvzSeN/D3f3PFZQaAW49wDsl8vtNCuOyPasornX9h4WpNVpi UFgXIK3XUx3V0JLQLC8kfW0DRhSF3GsjGnmABPtyaWHQrBcJcebR27A3Jxv/ITU3QvTT TOGLD0t8jm45dlfB2GDMclhttGxTeatPnAOHHOj3a37btiJXbkfGAKX6v9g/Y3fulpMq 4Eo5YNNoQsJu7ph2Hc/kWJ9ZnQg+V4qzFs1K22JLJrX+RQuJegbAMMB+y2jun3CqIYdK exOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=d9zVZwlqfxk3r02GC83eRqfK1jfcMoHpVJD96xlT3NA=; b=mZd2cI/oHKlyrfMKKmvuc9eDyTHrS++aMogiUpV4gtfKmsP1UNXWIcixJ94UxUyytf 76lmDlvpTsFtE8miihydp558C8HM1tHHTbrI3huSRVdAUpm0Ou6QG3Ifwn5/dWxruJ3H C94G7QJ4I4r1bq4Y1qWAOs7dhMv7rnFKx1lCGTtP4bZNxEyod3zDtL3ovbSlYfmzt1OM YTn0VCgtR5r0iCoTBTz76TQ8JaZ5rE49ZdKaV9HP23e2YvBKdfTEtFQf+Sa03ktpHuOS Xtw+iUVqyhJ4oebPrrPUvAQVncofI5bSI4/nrq2ONYZEdgPLHdU4P74cvIiZbixyh8H5 /0JA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BIQ0Hktf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l25si7432585pgn.63.2021.05.05.05.40.04; Wed, 05 May 2021 05:40:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BIQ0Hktf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233336AbhEEMkO (ORCPT + 99 others); Wed, 5 May 2021 08:40:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:56166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbhEEMkN (ORCPT ); Wed, 5 May 2021 08:40:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A2090608FE; Wed, 5 May 2021 12:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620218357; bh=54dU6dSYiEntoujKHzkvNojxOEYRfhM+A67m4LrvzSA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BIQ0HktfI4mtijUjcT18t4NFvBX/GgxkwzVxYeUvF3KexwRxv6BrPpu1mou61loSD 9Z7i5Wyy7nCRDpIsQhSGT2sZ7lqkoOM1ptUXJAjJKueyMRzS6hmwfOytBfY6L1kIbl DmR/GiIyBrL13mLFTaWddeaMs9+33g69YjfiVTwOtHRPLObh0aStidVqMj7MQGXeW6 XJa/v7ATnPoyKYOyLnxdpkBS1DtQ5zAFqvtbWt16FcmPeD4PDFG/l7GeTB5Dq3GsSa +pKdmo55rlI0Y6Wx7UmMd7BoBDq1XaJRYrllaZ8t7FvGROeoAcGLCrrqYWbJNK2ceQ QZe4ZOGeAGi+w== Date: Wed, 5 May 2021 13:38:40 +0100 From: Mark Brown To: Lukas Wunner Cc: Saravana Kannan , kernel-team@android.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] spi: Don't have controller clean up spi device before driver unbind Message-ID: <20210505123840.GA4541@sirena.org.uk> References: <20210505031416.30128-1-saravanak@google.com> <20210505054838.GA22603@wunner.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5vNYLRcllDrimb99" Content-Disposition: inline In-Reply-To: <20210505054838.GA22603@wunner.de> X-Cookie: Please ignore previous fortune. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5vNYLRcllDrimb99 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 05, 2021 at 07:48:38AM +0200, Lukas Wunner wrote: > As I've written yesterday, calling spi_cleanup() in > spi_unregister_device() should be fine if you move it to the end > of the function, but before the final put_device(). For that, > you need to open code the calls to device_del() and put_device() > that happen in device_unregister() so far. Indeed. --5vNYLRcllDrimb99 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmCSkdAACgkQJNaLcl1U h9C8JQf+NaV0aho4M5PbriQYD/9COSKhGGUdlZypLj/s+ZRCIRXjryamrFajafek YqpStp4it+gRDz7Pg8W2vWA0QpvzA+O/KWM5DQJ+hwgUqiVffe5N8zIKhdmwFsTB hUwfuZ4Eg7TWC7KjK/0yuWn3+CH5+st5eqYO9aYhtEYV3POTVIxJajUgMcihOfpp bWDnNOfG05OkVIlABAoGslHpcSOigrl3YcQAKneIGaQXH8Plh/AGU5ryRNNAGSyw l+5lMmea74lJdfjs53bg6Z951S1VyTB4AJeeGRyaB5Squbj4+ieAdj5VqQaP9qwi DUeape1mbA8Gz/8ASfCIMnnHML9zRw== =CEzc -----END PGP SIGNATURE----- --5vNYLRcllDrimb99--