Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp493919pxy; Wed, 5 May 2021 07:12:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAJE1OLC/bnEGBXmoYQdxkrsrQMo8dvWivaJ3THKfWcOw32NpZK/bk6T0Mc7qCxqrPtt28 X-Received: by 2002:a17:907:75f6:: with SMTP id jz22mr27194443ejc.504.1620223922118; Wed, 05 May 2021 07:12:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620223922; cv=none; d=google.com; s=arc-20160816; b=cYsNmivTB5AwhLWE4PFo9tzR+6m3aBpBnXyBl4QjxK+dBYeOVp0QaD1PZldo8aztww ruk8cYnAwgFa1d0JlUL/LlBZtQbMhXBX1zYgvyCls8HA9XwI+6u8u+7N+HjxMBGRSs85 JECXDYJn3q8bsh02xOZyALZMxQsDHcbZDbhk+wm1yGn7RbsFZHOf+jeY5wxBu3RcJBW5 u2mhz0lml7Kh6ryZsYuJaqUysHotXAZyD/dSdoSJOmT4SGs2TerB5G7lwHgnGtRbn0cN pslAYmlS5EacKOL+AS41Mt6mt47s92ATB7lEe9pJKhAhYsCD9pXbrDEv9Yi6JFlB5NzI iVrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/1GSOeA2KqNuHlcE9JSKb9GUcqaaMn/ztr/eGfvYt0o=; b=B/IWUa9X+X4mG6TW4/GRCmoc+6/puvKkKaFs8vMjm/hD6RP7c6nmawMw3XYTUmAJSi a1B693nH1hpuF9BLbzd8yUMqUMvInr7LoLBBdwwVXyOZCxgEY71N/td/AvwOaicUYcNP OGzbnTViso4xiEBtgVzvZ/tU2CEfIffB/wC73EYJzSsGZjeAuCcbL+BzBvdyeI5fWAit rdlL0xCj6wmDe/h3/wTpPv4OaQSlYwCcWTjXfxTyOA38woj8Bh/xdvxrfkN6v8Kn4F7h FgTqP9cttk7CR73oPwdV9ASv43hvFLifQrxB0AmO8uS3vIwpNxxYgg6pc1to8QqXyVNW bt4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="J/fGDCCn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ka11si5347688ejc.663.2021.05.05.07.11.35; Wed, 05 May 2021 07:12:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="J/fGDCCn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233794AbhEEMM0 (ORCPT + 99 others); Wed, 5 May 2021 08:12:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:53680 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233247AbhEEMJy (ORCPT ); Wed, 5 May 2021 08:09:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A6CA613B3; Wed, 5 May 2021 12:08:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620216528; bh=26mePQ+wt1RccbI5sBb0rvFETlyfZAcUQRUIStFj+Lk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J/fGDCCnRQu3MUYRcDQtt8pAyZWpQF9z/rDvSAJkj3gYDswHfpMDfkZP1C6BdGgTt litsAklJ176QZ2javS7fCd2nt14Ak/fY1ZQz7nGoBiL6nE4VT0HEhCqdhsdnEvwBeH JmcB2O8ct+sv0vP7J4ja9kMpHu03UXdMkviTPebA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christoph Hellwig , Jianxiong Gao , Konrad Rzeszutek Wilk Subject: [PATCH 5.11 16/31] swiotlb: factor out a nr_slots helper Date: Wed, 5 May 2021 14:06:05 +0200 Message-Id: <20210505112327.190783129@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210505112326.672439569@linuxfoundation.org> References: <20210505112326.672439569@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jianxiong Gao commit: c32a77fd18780a5192dfb6eec69f239faebf28fd Factor out a helper to find the number of slots for a given size. Signed-off-by: Christoph Hellwig Acked-by: Jianxiong Gao Tested-by: Jianxiong Gao Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Jianxiong Gao Signed-off-by: Greg Kroah-Hartman --- kernel/dma/swiotlb.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -194,6 +194,11 @@ static inline unsigned long io_tlb_offse return val & (IO_TLB_SEGSIZE - 1); } +static inline unsigned long nr_slots(u64 val) +{ + return DIV_ROUND_UP(val, IO_TLB_SIZE); +} + /* * Early SWIOTLB allocation may be too early to allow an architecture to * perform the desired operations. This function allows the architecture to @@ -493,20 +498,20 @@ phys_addr_t swiotlb_tbl_map_single(struc tbl_dma_addr &= mask; - offset_slots = ALIGN(tbl_dma_addr, IO_TLB_SIZE) >> IO_TLB_SHIFT; + offset_slots = nr_slots(tbl_dma_addr); /* * Carefully handle integer overflow which can occur when mask == ~0UL. */ max_slots = mask + 1 - ? ALIGN(mask + 1, IO_TLB_SIZE) >> IO_TLB_SHIFT + ? nr_slots(mask + 1) : 1UL << (BITS_PER_LONG - IO_TLB_SHIFT); /* * For mappings greater than or equal to a page, we limit the stride * (and hence alignment) to a page size. */ - nslots = ALIGN(alloc_size, IO_TLB_SIZE) >> IO_TLB_SHIFT; + nslots = nr_slots(alloc_size); if (alloc_size >= PAGE_SIZE) stride = (1 << (PAGE_SHIFT - IO_TLB_SHIFT)); else @@ -602,7 +607,7 @@ void swiotlb_tbl_unmap_single(struct dev enum dma_data_direction dir, unsigned long attrs) { unsigned long flags; - int i, count, nslots = ALIGN(alloc_size, IO_TLB_SIZE) >> IO_TLB_SHIFT; + int i, count, nslots = nr_slots(alloc_size); int index = (tlb_addr - io_tlb_start) >> IO_TLB_SHIFT; phys_addr_t orig_addr = io_tlb_orig_addr[index];