Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210429103751.v1.1.Ic231ad3cfa66df90373578777cf7cdc7f0e8f2ae@changeid>
In-Reply-To: <20210429103751.v1.1.Ic231ad3cfa66df90373578777cf7cdc7f0e8f2ae@changeid>
From:   Yu Liu <yudiliu@google.com>
Date:   Wed, 5 May 2021 09:07:06 -0700
Message-ID: <CAHC-ybzmwCSbYXRAvUEih6C+H7obkD64OS72QXaOfS_MPOpDDQ@mail.gmail.com>
Subject: Re: [PATCH v1] Bluetooth: Add a new MGMT error code for 0x3E HCI error
To:     linux-bluetooth@vger.kernel.org,
        Marcel Holtmann <marcel@holtmann.org>
Cc:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

ping for attention.

On Thu, Apr 29, 2021 at 10:38 AM Yu Liu <yudiliu@google.com> wrote:
>
> This is to enable us to retry the pairing in the user space if this
> failure is encountered
>
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
>
> Signed-off-by: Yu Liu <yudiliu@google.com>
> ---
>
> Changes in v1:
> - Initial change
>
>  include/net/bluetooth/mgmt.h | 1 +
>  net/bluetooth/mgmt.c         | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
> index a03c62b1dc2f..78b94577a7d8 100644
> --- a/include/net/bluetooth/mgmt.h
> +++ b/include/net/bluetooth/mgmt.h
> @@ -45,6 +45,7 @@
>  #define MGMT_STATUS_RFKILLED           0x12
>  #define MGMT_STATUS_ALREADY_PAIRED     0x13
>  #define MGMT_STATUS_PERMISSION_DENIED  0x14
> +#define MGMT_STATUS_CONNECT_NOT_ESTD   0x15
>
>  struct mgmt_hdr {
>         __le16  opcode;
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index b44e19c69c44..9e44c04d4212 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -271,7 +271,7 @@ static const u8 mgmt_status_table[] = {
>         MGMT_STATUS_INVALID_PARAMS,     /* Unsuitable Connection Interval */
>         MGMT_STATUS_TIMEOUT,            /* Directed Advertising Timeout */
>         MGMT_STATUS_AUTH_FAILED,        /* Terminated Due to MIC Failure */
> -       MGMT_STATUS_CONNECT_FAILED,     /* Connection Establishment Failed */
> +       MGMT_STATUS_CONNECT_NOT_ESTD,   /* Connection Establishment Failed */
>         MGMT_STATUS_CONNECT_FAILED,     /* MAC Connection Failed */
>  };
>
> --
> 2.31.1.527.g47e6f16901-goog
>