Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp652261pxy; Wed, 5 May 2021 10:22:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUoh0l0s9F8RGRsiStZy8X0Ix4507EDn7kjZFtZ6PvAVRGKi8Ma7cmasHPdI4cudRsLrlS X-Received: by 2002:a17:90a:7d02:: with SMTP id g2mr12357759pjl.153.1620235341425; Wed, 05 May 2021 10:22:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620235341; cv=none; d=google.com; s=arc-20160816; b=DrcK4IGuJu4fUtPXLExMYP4w7iYXNPUG1s32rd/wvn0a/1noBWmHUze9sFmET9dKZ0 fzjsr0Lncen1wtQEWunbQBPayzM8phAu7er8vKSQOhDyQ17ADpNgMoRptZsHey8ggOBH EDvlgdymxBXMjVKQJtQ36OoTMl5xG7XysXKltBcFusPAz/iVefBlneK8zcEB7GZI6hZ1 28GEiiAY8CoLcP9GSSLY9GgNhEDMcBi+QAqZw83zY4z7VN5Bhshf3gCbrzlOrBHB8a+Z qRNVgGEkH9cmupQ5CBZbqHO3OsZAsAIs0s2dgWJDilDymceo2Ih0KzzOFiRKSI6Tn1pq 6enA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=xa8KW4CQIPOxnd2l+Wqdee+Ey20WzM1qUmVwdrD3UZg=; b=HIVGh0J3iD/3yeEZ6pS/0tUTwAreCF3SXNanQTWydU7xKuGWnZyYXhnlsXt3op9cFQ YXBnZJzQv0KCFLyPsBPQHaEj/AZKCLCuJlNTFu1jW07HF6UixsPR/UiHLTxltwehikEz 54q2x5ToQAJXHDa91KwbHrJ+L4aM1Y2tOEWHIgQFQ4eX63ImKcdHgpe0mHeDLdcVWjZO uQvjdtc2+QCFthXWAi0280r/MeOsq81XSIwhRLBUqF1cgHyd4Z8dZi+pTYlrz6k7dMSV bVsGpouyhCMWl4ctSaOiAFH26WxGZxhBeT7YznfJolaiwEV0x4Hyjki9mFPqgPi4dtGR +/AQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a7si6044886plp.64.2021.05.05.10.22.08; Wed, 05 May 2021 10:22:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240647AbhEERVb (ORCPT + 99 others); Wed, 5 May 2021 13:21:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:55388 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238102AbhEERJH (ORCPT ); Wed, 5 May 2021 13:09:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7F149B0EA; Wed, 5 May 2021 17:08:09 +0000 (UTC) Date: Wed, 5 May 2021 19:08:12 +0200 From: Borislav Petkov To: Andrew Halaney Cc: Steven Rostedt , Randy Dunlap , akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] init: Print out unknown kernel parameters Message-ID: References: <20210503213400.27360-1-ahalaney@redhat.com> <20210503184606.5e8461c0@gandalf.local.home> <20210504152614.mgiihv4ukqajo3jb@halaneylaptop> <20210505163728.oh7rqpdvxrdilmfk@halaneylaptop> <20210505165542.tpptt5g7ffxcfmxe@halaneylaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210505165542.tpptt5g7ffxcfmxe@halaneylaptop> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 05, 2021 at 11:55:42AM -0500, Andrew Halaney wrote: > Ah, but don't worry! It is handled, just secretly: > unknown_bootoption()->obsolete_checksetup() walks __setup_start > :) Eww, and there's a had_early_param - run-this-function-only-one-time clumsy thing. Here's another area that could use a cleanup. > Still worth considering, so at least lemme ponder it for a day instead > of being lazy. Take your time - that's one of those fun projects where no one's breathing down your neck. And remember to have fun, as we say. :-) -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg