Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] dt-bindings: i2c: Move i2c-omap.txt to YAML format
To:     Tony Lindgren <tony@atomide.com>
CC:     Rob Herring <robh+dt@kernel.org>, <linux-omap@vger.kernel.org>,
        <linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Nishanth Menon <nm@ti.com>
References: <20210505065511.918-1-vigneshr@ti.com>
 <YJJGsGXBz56Nhe8z@atomide.com>
From:   Vignesh Raghavendra <vigneshr@ti.com>
Message-ID: <ade03294-6c1a-ce10-1ac9-c67c8e51b137@ti.com>
Date:   Wed, 5 May 2021 23:34:46 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YJJGsGXBz56Nhe8z@atomide.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 5/5/21 12:48 PM, Tony Lindgren wrote:
> Hi,
> 
> * Vignesh Raghavendra <vigneshr@ti.com> [210505 06:55]:
>> Convert i2c-omap.txt to YAML schema for better checks and documentation.
> 
> Nice to see this happening, few minor comments below on handling the
> legacy devices.
> 
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - const: ti,omap2420-i2c
>> +      - const: ti,omap2430-i2c
>> +      - const: ti,omap3-i2c
>> +      - const: ti,omap4-i2c
>> +      - items:
>> +          - enum:
>> +              - ti,am4372-i2c
>> +              - ti,am64-i2c
>> +              - ti,am654-i2c
>> +              - ti,j721e-i2c
>> +          - const: ti,omap4-i2c
> 
> I wonder if we should just add all the compatible options to the
> driver, and have all these as oneOf?
> 

This would also need updates to dts files too. Also not a fan of adding
all compatibles to driver code unless required.

>> +  ti,hwmods:
>> +    description:
>> +      Must be "i2c<n>", n being the instance number (1-based)
>> +    $ref: /schemas/types.yaml#/definitions/string
>> +    items:
>> +      - pattern: "^i2c([1-9])$"
> 
> The ti,hwmods is a legacy property that is only needed for omap2/3 and
> ti81xx. At least the description should mention that to avoid folks
> adding it accidentally.
> 

Sure, will do in v2. Thanks for the review!


Regards
Vignesh