Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 05 May 2021 13:27:39 -0700 (PDT)
Message-Id: <20210505.132739.2022645880622422332.davem@davemloft.net>
To:     u.kleine-koenig@pengutronix.de
Cc:     axboe@kernel.dk, kuba@kernel.org, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, sparclinux@vger.kernel.org,
        linux-block@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] sparc/vio: make remove callback return void
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20210505201449.195627-1-u.kleine-koenig@pengutronix.de>
References: <20210505201449.195627-1-u.kleine-koenig@pengutronix.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Date: Wed,  5 May 2021 22:14:49 +0200

> The driver core ignores the return value of struct bus_type::remove()
> because there is only little that can be done. To simplify the quest to
> make this function return void, let struct vio_driver::remove() return
> void, too. All users already unconditionally return 0, this commit makes
> it obvious that returning an error code is a bad idea and should prevent
> that future driver authors consider returning an error code.
> 
> Note there are two nominally different implementations for a vio bus:
> one in arch/sparc/kernel/vio.c and the other in
> arch/powerpc/platforms/pseries/vio.c. This patch only addresses the
> former.
> 
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

Acked-by: David S. Miller <davem@davemloft.net>