Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 6 May 2021 00:41:21 +0200
From:   Pablo Neira Ayuso <pablo@netfilter.org>
To:     Pallavi Prabhu <rpallaviprabhu@gmail.com>
Cc:     kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net,
        yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org,
        netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv6: netfilter.c: fix missing line after declaration
Message-ID: <20210505224121.GA23510@salvia>
References: <20210505192007.GA12080@pallavi>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210505192007.GA12080@pallavi>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Hi Pallavi,

On Thu, May 06, 2021 at 12:50:07AM +0530, Pallavi Prabhu wrote:
> Fixed a missing line after a declaration for proper coding style.

I'd probably suggest to use Coccinelle or similar to make a Netfilter
tree wide patch to add line after a declaration.

Probably there are more spots in the Netfilter codebase that can
benefit from this cleanup.

> Signed-off-by: Pallavi Prabhu <rpallaviprabhu@gmail.com>
> ---
>  net/ipv6/netfilter.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/ipv6/netfilter.c b/net/ipv6/netfilter.c
> index ab9a279dd6d4..7b1671f48593 100644
> --- a/net/ipv6/netfilter.c
> +++ b/net/ipv6/netfilter.c
> @@ -81,6 +81,7 @@ static int nf_ip6_reroute(struct sk_buff *skb,
>  
>  	if (entry->state.hook == NF_INET_LOCAL_OUT) {
>  		const struct ipv6hdr *iph = ipv6_hdr(skb);
> +
>  		if (!ipv6_addr_equal(&iph->daddr, &rt_info->daddr) ||
>  		    !ipv6_addr_equal(&iph->saddr, &rt_info->saddr) ||
>  		    skb->mark != rt_info->mark)
> -- 
> 2.25.1
>