Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp977266pxy; Wed, 5 May 2021 19:57:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy36byS4xoK+pEK4/GbHIFr7afxXyjWVHlA+SwPgF8TkVFX+8Nq8dv0Yw+JvSxgZAPNLtGP X-Received: by 2002:a17:90b:3796:: with SMTP id mz22mr14592942pjb.80.1620269867196; Wed, 05 May 2021 19:57:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620269867; cv=none; d=google.com; s=arc-20160816; b=Xd8H0KJCl0xE6TRuxXzR+HKc0ZmpGz0YpGvS3IDN4OlHtRJXNb8yDgm4F2tVHbFynn Wwzkg2GSAhUJ4Ne5cQs1CP9AxdXFUnBsVYT6laXpHzVbxWBHSbSi899+9oCRv3DCjjCV h1QwgPTZW3yF4+D3WdM3wf+arBH4nXb0xu8VX0sozKkY9taKrL6WPs2uSgzCnDjtE4Ny 76TyJWsR++nYS7vqMoxdkBKY8/zenUPIoa1WE6xriK4ljQ/BeRaR6zDZXuCN6VGHo4MJ C9CVFh+EBj5kl8sRqBo4Opjm5AbT8zA/WRlKo/JkY4i2eQzutCwnpTUIOb2AK2V45ARN 8XaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=NHU3Un01K0u3laCe341iOR3pdvPbWfi3lhWKyIawAiI=; b=iMPO8b9Qwwo5Qnsk82gmv87Fsv84PaVuNNxYIufztRo/vfHA6D3NGuI7mRKfIKyJBr hFobRZXNsTFG7bcGZycodOcWxNY4/Ue5DaIoYTM3EiIEi5yeMWEBBOFXpn7crjk37OPG WTXfWev34eK5ZRpJnFcryoFLGMOSAW2RAKqhxd4rsIKj5hoiFeiTJtsBiBgkDGb89nP4 arlZ+CpNKbwfx15+U2eHEXxzxmqzke+/ruMbJjx5lcQjq/NiVEqo4yaHURBy5AL7GO/H 6/ymoeeYGlvFnqO8BKLnxGO4cMFxyPPoNMmoghUgeVlNf59xZ/Q3s8kBk+IAI4iogYEx CZCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e15si1360972pgn.139.2021.05.05.19.57.34; Wed, 05 May 2021 19:57:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231167AbhEFCyI (ORCPT + 99 others); Wed, 5 May 2021 22:54:08 -0400 Received: from inva021.nxp.com ([92.121.34.21]:38110 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229465AbhEFCyG (ORCPT ); Wed, 5 May 2021 22:54:06 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 54BEF20065A; Thu, 6 May 2021 04:53:07 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 3F71320067D; Thu, 6 May 2021 04:53:03 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id C6AE44034D; Thu, 6 May 2021 04:46:35 +0200 (CEST) From: Shengjiu Wang To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: imx-pcm-rpmsg: Fix warning of incorrect type in assignment Date: Thu, 6 May 2021 10:30:40 +0800 Message-Id: <1620268240-1005-1-git-send-email-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.7.4 X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The format in rpmsg is defained as unsigned char, there is warning when convert snd_pcm_format_t to it. sound/soc/fsl/imx-pcm-rpmsg.c:164:43: sparse: warning: incorrect type in assignment (different base types) sound/soc/fsl/imx-pcm-rpmsg.c:164:43: sparse: expected unsigned char format sound/soc/fsl/imx-pcm-rpmsg.c:164:43: sparse: got restricted snd_pcm_format_t [usertype] sound/soc/fsl/imx-pcm-rpmsg.c:167:43: sparse: warning: incorrect type in assignment (different base types) sound/soc/fsl/imx-pcm-rpmsg.c:167:43: sparse: expected unsigned char format sound/soc/fsl/imx-pcm-rpmsg.c:167:43: sparse: got restricted snd_pcm_format_t [usertype] Refine the unused RPMSG_DSD_U16_LE and RPMSG_DSD_U32_LE for these case to fix this sparse warning. Fixes: 3c00eceb2a53 ("ASoC: imx-pcm-rpmsg: Add platform driver for audio base on rpmsg") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/imx-pcm-rpmsg.c | 4 ++-- sound/soc/fsl/imx-pcm-rpmsg.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/imx-pcm-rpmsg.c b/sound/soc/fsl/imx-pcm-rpmsg.c index 875c0d6df339..3f5913adbfb0 100644 --- a/sound/soc/fsl/imx-pcm-rpmsg.c +++ b/sound/soc/fsl/imx-pcm-rpmsg.c @@ -161,10 +161,10 @@ static int imx_rpmsg_pcm_hw_params(struct snd_soc_component *component, msg->s_msg.param.format = RPMSG_S24_LE; break; case SNDRV_PCM_FORMAT_DSD_U16_LE: - msg->s_msg.param.format = SNDRV_PCM_FORMAT_DSD_U16_LE; + msg->s_msg.param.format = RPMSG_DSD_U16_LE; break; case SNDRV_PCM_FORMAT_DSD_U32_LE: - msg->s_msg.param.format = SNDRV_PCM_FORMAT_DSD_U32_LE; + msg->s_msg.param.format = RPMSG_DSD_U32_LE; break; default: msg->s_msg.param.format = RPMSG_S32_LE; diff --git a/sound/soc/fsl/imx-pcm-rpmsg.h b/sound/soc/fsl/imx-pcm-rpmsg.h index 308d153920a3..8286b55f00ae 100644 --- a/sound/soc/fsl/imx-pcm-rpmsg.h +++ b/sound/soc/fsl/imx-pcm-rpmsg.h @@ -328,9 +328,9 @@ #define RPMSG_S16_LE 0x0 #define RPMSG_S24_LE 0x1 #define RPMSG_S32_LE 0x2 -#define RPMSG_DSD_U16_LE 0x3 +#define RPMSG_DSD_U16_LE 49 /* SNDRV_PCM_FORMAT_DSD_U16_LE */ #define RPMSG_DSD_U24_LE 0x4 -#define RPMSG_DSD_U32_LE 0x5 +#define RPMSG_DSD_U32_LE 50 /* SNDRV_PCM_FORMAT_DSD_U32_LE */ #define RPMSG_CH_LEFT 0x0 #define RPMSG_CH_RIGHT 0x1 -- 2.17.1