Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 6 May 2021 08:11:21 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     David Miller <davem@davemloft.net>
Cc:     axboe@kernel.dk, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        kernel@pengutronix.de, netdev@vger.kernel.org,
        sparclinux@vger.kernel.org, kuba@kernel.org, jirislaby@kernel.org
Subject: Re: [PATCH] sparc/vio: make remove callback return void
Message-ID: <20210506061121.3flqmvm4jok6zj5z@pengutronix.de>
References: <20210505201449.195627-1-u.kleine-koenig@pengutronix.de>
 <20210505.132739.2022645880622422332.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7ykpqbhtw2snraxa"
Content-Disposition: inline
In-Reply-To: <20210505.132739.2022645880622422332.davem@davemloft.net>
Precedence: bulk


--7ykpqbhtw2snraxa
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Dave,

On Wed, May 05, 2021 at 01:27:39PM -0700, David Miller wrote:
> From: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> Date: Wed,  5 May 2021 22:14:49 +0200
>=20
> > The driver core ignores the return value of struct bus_type::remove()
> > because there is only little that can be done. To simplify the quest to
> > make this function return void, let struct vio_driver::remove() return
> > void, too. All users already unconditionally return 0, this commit makes
> > it obvious that returning an error code is a bad idea and should prevent
> > that future driver authors consider returning an error code.
> >=20
> > Note there are two nominally different implementations for a vio bus:
> > one in arch/sparc/kernel/vio.c and the other in
> > arch/powerpc/platforms/pseries/vio.c. This patch only addresses the
> > former.
> >=20
> > Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
>=20
> Acked-by: David S. Miller <davem@davemloft.net>

Thanks for your Ack. My expectation was that this patch will go via a
sparc tree. Does your Ack mean that you think it should take a different
path?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--7ykpqbhtw2snraxa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmCTiIYACgkQwfwUeK3K
7Akyewf9GGuVOF+VCCZkBtEvuUsC2Pxxc/JoxB5DmIocsggrrpOh06j+LsYO0PKf
SUD3UB48kEWMEn7yvaPyYqM/5A5GZy/vvJb65UEMOrGjWz+x8nJUwxeUZZ9oUgje
mZglUAbfvEQfUCVAgnxjzn9Wp0WQAQ3RaShkT8QvFJ63fZHrbjkGbm9eRDf2Kktk
/V3ZULOJ1kHPT+XF8lGBQ58KRktmYht0T6+Mykc90usi+v7xQW6Wv/bRBETpOI3q
8nZQDDUdjxI/6AfPUPHReZwffZW8d8uEWvGoQhN+s+vfD0MgDua+EYPibke7VQQL
LPvVc0yb5Ye5diDYK6uaKxDbwBeLdg==
=OqA9
-----END PGP SIGNATURE-----

--7ykpqbhtw2snraxa--