Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <baa95d7235921dff23bed6320518f3fa90396603.1612681353.git.fthain@telegraphics.com.au>
In-Reply-To: <baa95d7235921dff23bed6320518f3fa90396603.1612681353.git.fthain@telegraphics.com.au>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Thu, 6 May 2021 09:19:44 +0200
Message-ID: <CAMuHMdVurQcwHcP7QnOrxLVuqUAnokJ-2R+11FOyG-htS9Fu9w@mail.gmail.com>
Subject: Re: [PATCH] m68k: Drop -fno-strength-reduce from KBUILD_CFLAGS
To:     Finn Thain <fthain@telegraphics.com.au>
Cc:     linux-m68k <linux-m68k@lists.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Feb 7, 2021 at 8:08 AM Finn Thain <fthain@telegraphics.com.au> wrote:
> This workaround became redundant either when the driver in question was
> removed (in Linux v2.6.23) or when the compiler flag became a no-op
> (in GCC v4.2). Linux has required GCC v4.6 or later since v4.19.
>
> Link: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=efa1cdf01850b28c2f6f7035ebd4420259494615
> References: commit 565bae6a4a8f ("[SCSI] 53c7xx: kill driver")
> References: commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue in the m68k for-v5.14 branch.

> --- a/arch/m68k/Makefile
> +++ b/arch/m68k/Makefile
> @@ -66,8 +66,7 @@ KBUILD_CFLAGS += $(cpuflags-y)
>  KBUILD_CFLAGS += -pipe -ffreestanding
>
>  ifdef CONFIG_MMU
> -# without -fno-strength-reduce the 53c7xx.c driver fails ;-(
> -KBUILD_CFLAGS += -fno-strength-reduce -ffixed-a2
> +KBUILD_CFLAGS += -ffixed-a2
>  else
>  # we can use a m68k-linux-gcc toolchain with these in place
>  KBUILD_CPPFLAGS += -DUTS_SYSNAME=\"uClinux\"

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds