Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] media: em28xx: Fix possible memory leak of em28xx
 struct
To:     Shuah Khan <skhan@linuxfoundation.org>,
        Igor Matheus Andrade Torrente <igormtorrente@gmail.com>,
        mchehab@kernel.org
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210504183249.6307-1-igormtorrente@gmail.com>
 <21f59c86-f1ae-5913-cde9-078fe4f6f752@linuxfoundation.org>
From:   Hans Verkuil <hverkuil-cisco@xs4all.nl>
Message-ID: <cc3a655a-e29d-34f1-a1bb-faab01a1f756@xs4all.nl>
Date:   Thu, 6 May 2021 09:43:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <21f59c86-f1ae-5913-cde9-078fe4f6f752@linuxfoundation.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05/05/2021 17:54, Shuah Khan wrote:
> On 5/4/21 2:32 PM, Igor Matheus Andrade Torrente wrote:
>> The em28xx struct kref isn't being decreased after an error in the
>> em28xx_ir_init, leading to a possible memory leak.
>>
>> A kref_put and em28xx_shutdown_buttons is added to the error handler code.
>>
>> Signed-off-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
>> ---
> 
> Hi Igor,
> 
> Please look at Hans's response and comments to your v1 patch. v4l core
> addresses the lifetime issues now and this driver could be updated to
> use them instead if fixing the problems in this driver's resource
> lifetime mgmt code.

Actually, this patch is fine (I think, still need to review it). This is
related to the input part, not v4l2.

Regards,

	Hans

> 
> Please follow his review comments to address the issue based on his 
> suggestions.
> 
> thanks,
> -- Shuah
>