Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] f2fs: set file as cold when file defragmentation
To:     Jaegeuk Kim <jaegeuk@kernel.org>
CC:     <daejun7.park@samsung.com>, "chao@kernel.org" <chao@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-f2fs-devel@lists.sourceforge.net" 
        <linux-f2fs-devel@lists.sourceforge.net>
References: <CGME20210429062005epcms2p352ef77f96ab66cbffe0c0ab6c1b62d8a@epcms2p3>
 <20210429062005epcms2p352ef77f96ab66cbffe0c0ab6c1b62d8a@epcms2p3>
 <3a0ab201-9546-d523-abc7-79df5f637f14@huawei.com>
 <YJN0nTgadoq8vDaG@google.com>
From:   Chao Yu <yuchao0@huawei.com>
Message-ID: <bd0fa15b-01c3-9f70-3eb8-ec2b54a0ee8f@huawei.com>
Date:   Thu, 6 May 2021 14:36:12 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <YJN0nTgadoq8vDaG@google.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/5/6 12:46, Jaegeuk Kim wrote:
> On 05/06, Chao Yu wrote:
>> On 2021/4/29 14:20, Daejun Park wrote:
>>> In file defragmentation by ioctl, all data blocks in the file are
>>> re-written out-of-place. File defragmentation implies user will not update
>>> and mostly read the file. So before the defragmentation, we set file
>>> temperature as cold for better block allocation.
>>
>> I don't think all fragmented files are cold, e.g. db file.
> 
> I have a bit different opinion. I think one example would be users want to
> defragment a file, when the they want to get higher read bandwidth for

Multimedia file was already defined as cold file now via default extension
list?

> usually multimedia files. That's likely to be cold files. Moreover, I don't
> think they want to defragment db files which will be fragmented soon?

I guess like db files have less update but more access?

Thanks,

> 
>>
>> We have separated interface (via f2fs_xattr_advise_handler, e.g. setfattr -n
>> "system.advise" -v value) to indicate this file is a hot/cold file, so my
>> suggestion is after file defragmentation, if you think this file is cold, and
>> use setxattr() to set it as cold.
>>
>> Thanks,
>>
>>>
>>> Signed-off-by: Daejun Park <daejun7.park@samsung.com>
>>> ---
>>>    fs/f2fs/file.c | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
>>> index d697c8900fa7..dcac965a05fe 100644
>>> --- a/fs/f2fs/file.c
>>> +++ b/fs/f2fs/file.c
>>> @@ -2669,6 +2669,9 @@ static int f2fs_defragment_range(struct f2fs_sb_info *sbi,
>>>    	map.m_len = pg_end - pg_start;
>>>    	total = 0;
>>> +	if (!file_is_cold(inode))
>>> +		file_set_cold(inode);
>>> +
>>>    	while (map.m_lblk < pg_end) {
>>>    		pgoff_t idx;
>>>    		int cnt = 0;
>>>
> .
>