Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932314AbWJVJZD (ORCPT ); Sun, 22 Oct 2006 05:25:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932315AbWJVJZD (ORCPT ); Sun, 22 Oct 2006 05:25:03 -0400 Received: from 85.8.24.16.se.wasadata.net ([85.8.24.16]:59537 "EHLO smtp.drzeus.cx") by vger.kernel.org with ESMTP id S932314AbWJVJZC (ORCPT ); Sun, 22 Oct 2006 05:25:02 -0400 Message-ID: <453B38EF.6050201@drzeus.cx> Date: Sun, 22 Oct 2006 11:25:03 +0200 From: Pierre Ossman User-Agent: Thunderbird 1.5.0.7 (X11/20061008) MIME-Version: 1.0 To: Russell King CC: Timo Teras , linux-kernel@vger.kernel.org Subject: Re: [PATCH] MMC: Select only one voltage bit in OCR response References: <20061009150044.GB1637@mail.solidboot.com> <20061009165317.GA6431@flint.arm.linux.org.uk> <20061009172350.GC1637@mail.solidboot.com> <453327EC.1000402@drzeus.cx> In-Reply-To: <453327EC.1000402@drzeus.cx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1075 Lines: 29 (In case you've missed it) Pierre Ossman wrote: > Timo Teras wrote: >> I see. But if we do send an OCR with an unsupported bit set, the card will >> go to inactive state and is unusable. This problem is masked on controllers >> with only 3.3V support, but I'm working with a controller supporting several >> different voltages. >> >> For example, I have a card giving an OCR reply of 0x0ff80080. The current >> code will reply to this with 0x00000180 which is clearly incorrect. >> >> Maybe something like "ocr &= 3 << bit;" would be more approriate? >> > > Russell? Comments? Do you still have the offending card? > -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/