Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp1212756pxy; Thu, 6 May 2021 03:07:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoSmxAXAuQvDBgFQCOu4NSXuZpM3gyk61eANJ3BMUpUyM6WQGT3laalqHSeKBQItjGaIVP X-Received: by 2002:a05:6402:c7:: with SMTP id i7mr4301833edu.194.1620295630472; Thu, 06 May 2021 03:07:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620295630; cv=none; d=google.com; s=arc-20160816; b=mQ4tiFbbwUOnWFec5VWRwSlChhyh/CTNFfyinsAsJGiykWBNZZ9C6EjIgdSYAtELrR Rp28d1WuCHNDdmnGfUxsSp5sTzE6QutuTNjMSqLYs3ksM1hR85I4I/eZZmYY6outL2xf uhHjXzz7YA924vFgqYGZUkyrRR9Au4sY9dCwUdAnhTBT0gVbYhv455/DdLNlCbupt9tm bCm5OHWAbf7B7VWynfmKg3LAtkRB3AvjALo18GMdlRX6rXssNIDHCfIBhmWi1I270fTq M2mm5y7ad9nCVvWTmql9gVqiQ8VcxSsWgpdKZOYvL4JCpLz+4PqTS8PmycMowJSq96Ce OLBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Piv8ZYTfH5cowhsbdq6jOZaDTmGx3fgW4EatPYDQqqU=; b=MS3aaHZzh+3r9NF1xsMOsGWS/BNXBfUV+0vfIQLyAAcEOzNGZV4ud9XJgZ86s1g/mA WvX/zfhWoOgYQuo1FjYGS15/5QFZLxAHAgK1xny7kPE6h7vm9QT0jMjdmbtNdlMEKT99 umfDlSQX5jkZE+T5gHsHy5Dusr/llzvCXlSk+t31n/o9LKTySS33H1n2NvGZ0ziGuo+W SsM66hjPijzIlXm1WVkGDjsGhLHf7OFJfcl/jkfOr5JzNXtd4H1rbRXh5oIKzdfDtyHd 3oyhfM51plFFhvwn/+48jF4Y4z9vwReBDKXEMHqzLwx2ung/GEAGgkrdoZhaCIIxYUYw jgKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dr53OI1j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bv14si1918844ejb.737.2021.05.06.03.06.46; Thu, 06 May 2021 03:07:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dr53OI1j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233950AbhEFJFR (ORCPT + 99 others); Thu, 6 May 2021 05:05:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:40196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233765AbhEFJFR (ORCPT ); Thu, 6 May 2021 05:05:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 50434611AD; Thu, 6 May 2021 09:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620291859; bh=t5kO1RsBj6L282zo2Irz4ki0RAdod79K0nlUviJ0DRY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dr53OI1jURTtSScsXd57eUQ9+2gsxRRQ5HE8nSaQjtxPiDpLi1OUYk3IfWGj50WeL lsxXsfBKQNaS+YCt6aFGYEhLMDYppmMkoj2RghPGPa9dOnlYwDgW/Z1iB+QG4vmW4s Gk/1EOtZD7f4bze/Q7+pGvLY54pEPJ7s5rcpoS/0Hn4AkRYbBEge0u0HX+ubH1kQz6 Df12ZMnE4yAi3Tu3O9pFA/CxKkD3QLThxqeUZqxdIyCRbmUhgELaVBHyoi4xl7yE1L 9vqEGnKxBguWG2hgrXUaAhazZeSSIw595UkjoOy1VFO9RLIBgREWYGb/Yu4+PiIKR6 VMaEA2aSKQD0w== Date: Thu, 6 May 2021 12:04:14 +0300 From: Leon Romanovsky To: Xiaofei Tan Cc: jgg@ziepe.ca, liweihang@huawei.com, liangwenpeng@huawei.com, shiju.jose@huawei.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@openeuler.org Subject: Re: [PATCH] RDMA/ucma: Cleanup to reduce duplicate code Message-ID: References: <1620291106-3675-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1620291106-3675-1-git-send-email-tanxiaofei@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 06, 2021 at 04:51:46PM +0800, Xiaofei Tan wrote: > The lable "err1" does the same thing as the branch of copy_to_user() > failed in the function ucma_create_id(). Just jump to the label directly > to reduce duplicate code. > > Signed-off-by: Xiaofei Tan > --- > drivers/infiniband/core/ucma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky