Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210506105405.3535023-1-glider@google.com> <20210506105405.3535023-2-glider@google.com>
In-Reply-To: <20210506105405.3535023-2-glider@google.com>
From:   Marco Elver <elver@google.com>
Date:   Thu, 6 May 2021 13:11:24 +0200
Message-ID: <CANpmjNPY9AHGtuoYxOsB8UQLw4AaT0mY2bt+daKYtnjHE9MKtw@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] kasan: use dump_stack_lvl(KERN_ERR) to print stacks
To:     Alexander Potapenko <glider@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Petr Mladek <pmladek@suse.com>, Ingo Molnar <mingo@kernel.org>,
        bo.he@intel.com, yanmin_zhang@linux.intel.com,
        psodagud@quicinc.com, Dmitry Vyukov <dvyukov@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 6 May 2021 at 12:54, Alexander Potapenko <glider@google.com> wrote:
>
> Most of the contents of KASAN reports are printed with pr_err(), so use
> a consistent logging level to print the memory access stacks.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
> Cc: Prasad Sodagudi <psodagud@quicinc.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> Cc: Marco Elver <elver@google.com>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Alexander Potapenko <glider@google.com>

Reviewed-by: Marco Elver <elver@google.com>


> ---
>  mm/kasan/report.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index 14bd51ea2348..8fff1825b22c 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -230,7 +230,7 @@ static void print_address_description(void *addr, u8 tag)
>  {
>         struct page *page = kasan_addr_to_page(addr);
>
> -       dump_stack();
> +       dump_stack_lvl(KERN_ERR);
>         pr_err("\n");
>
>         if (page && PageSlab(page)) {
> @@ -375,7 +375,7 @@ void kasan_report_async(void)
>         pr_err("BUG: KASAN: invalid-access\n");
>         pr_err("Asynchronous mode enabled: no access details available\n");
>         pr_err("\n");
> -       dump_stack();
> +       dump_stack_lvl(KERN_ERR);
>         end_report(&flags, 0);
>  }
>  #endif /* CONFIG_KASAN_HW_TAGS */
> @@ -420,7 +420,7 @@ static void __kasan_report(unsigned long addr, size_t size, bool is_write,
>                 pr_err("\n");
>                 print_memory_metadata(info.first_bad_addr);
>         } else {
> -               dump_stack();
> +               dump_stack_lvl(KERN_ERR);
>         }
>
>         end_report(&flags, addr);
> --
> 2.31.1.527.g47e6f16901-goog
>