Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp1337390pxy; Thu, 6 May 2021 06:05:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoZjzdG4/X0mbRUc/qMc2sEGNf4TuBuum4s8Uqrbf3SPse9zuVcZ8K+AbsHTNPchdHoGAK X-Received: by 2002:a05:651c:325:: with SMTP id b5mr3227863ljp.214.1620306357367; Thu, 06 May 2021 06:05:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620306357; cv=none; d=google.com; s=arc-20160816; b=abJbGIDJroETv0LHATnXfPdxd2uK0lra4SCOddyRJ2xXoI4pJkktgeWsNKqQnDPwSm qS3IWMq/0YrAyDcf+dWXC8UIP0XOiEiBoC2eqAnanZkkKo0SXjLhY4jZkkbs/oS10713 PbXg2nKggFIHZaWJ4oU3rWLyw1b6q4NUSPE/j+tHC4THgmYNRZV/JwPitatn0jExdPIw I90OGCCV3o7jn/uoRR/5h5p/mrvHu6bImyHU53L9P+ZFYY66eEkAbps1QFXQdXsr3jir Y7Dqr723x19z8gH7cveFe8tqBgB+R8Kt0bPo3Bip4QQI9nbZpE3NvZbu//+qFCTwgpmq CPpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=hLhu4a2qeeKN1ThghHVgWBhHswj+unmP67cSTUVDirw=; b=kd8OEttc/IbUVX2Hc3kb+aZH//a/dpGW4zb8LT6lD+qkXFpoadJ9Vdije9ZqUDRkx4 dYNNI1tJfSbpaGDmLZ46j2QL1wboptXbltJ2BVz3UBcCH7hK23g9QH/AQOBf5fxYUVF0 YVYduE28vIpBUs0sGPKHx7G8jyFGER9FQgjpq3397H5SMCT5E+Fl1tukvdy9iZa8dK27 ZoBHXifofbe06+Gcu/NzF9A03km6KhfIm6OiDJVbF9f0hYmDe1VF8uXws8IWAzwHa0gv SBFREEqADzKqT2gmJqMlf81McQlQ/WKKsIgTbPM8hxi6vkPln5+mXwezgEmYw6MaYgEW XVCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JXcpFGSs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nb27si2245568ejc.548.2021.05.06.06.05.29; Thu, 06 May 2021 06:05:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JXcpFGSs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231265AbhEFNFZ (ORCPT + 99 others); Thu, 6 May 2021 09:05:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233115AbhEFNFY (ORCPT ); Thu, 6 May 2021 09:05:24 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74507C061761 for ; Thu, 6 May 2021 06:04:26 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id u25so6940414ljg.7 for ; Thu, 06 May 2021 06:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hLhu4a2qeeKN1ThghHVgWBhHswj+unmP67cSTUVDirw=; b=JXcpFGSsXkuwB65R3OnXVCm0UFidSXxrn6blltm71bquZl9btHIMhI9GAQYYzSaLeI xgea5q7+rY4XwJmcP9mtlaCMnDA83ceyMo6JrHum1coXn3p37qE9U56lv5OIqSsaxbi9 DU/ImjVgNR4X2YxaJiMt51dcjYeUDG4lVvJpsdksMADuvyLmNPbpWleWToY0IdzwE6tF MtfY64u//1KbZ12PZwct/ury/h9OOWaVaJh5L/AZhg+xeYJBhxqg/0QoovcSTRxEQtcn ZlK49trxBeYvOAUG2zFOe1Wx9qLNB8my0Haj49rwJqN/h3Vu7yrELBe6J5tmjUeRg8tg 6rAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hLhu4a2qeeKN1ThghHVgWBhHswj+unmP67cSTUVDirw=; b=sDbqF7lD3tf12ZQMBtakWDQLc7SxVSCNJkxwiUdrMtQIyuqjitD7bCEhMPLc1YF8mp 1Zf7imsaY/BkHClchITjFGKmj+efi03F2zZmJKlqTzUXAQoPLeaJLJvxzijb88hBHvst eKnaxdjTVwwUpXu5DdWrbykfA0Oc3GtFcGxd5veCsXJWbpKFJ9RvJQUwE3SyGiSER49j OQzqJXuwOm6IzRCEIVEueANXvFKj0fcAxRjhI4MmVEZQotXC7dLiZOCn/9z9QCEkTSbI eBLKP/DlODGqGZj5BCWQYWvXCn7muZS1QLZitIP/ceqzAA1G/zhEQe6Ej1gtGIc59RcK Fkxw== X-Gm-Message-State: AOAM530AJOWgqXZqOQ7ZvCzgIwgITxQM/mq+DsuUCBKg10Wgil8WHPda BTSa9A1Le1JDheD1HWE5Ly8YQEtqN0Rl24SBYAdMag== X-Received: by 2002:a2e:a369:: with SMTP id i9mr3212788ljn.273.1620306263997; Thu, 06 May 2021 06:04:23 -0700 (PDT) MIME-Version: 1.0 References: <20210504161222.101536-1-ulf.hansson@linaro.org> <20210504161222.101536-10-ulf.hansson@linaro.org> In-Reply-To: <20210504161222.101536-10-ulf.hansson@linaro.org> From: Linus Walleij Date: Thu, 6 May 2021 15:04:12 +0200 Message-ID: Subject: Re: [PATCH 09/11] mmc: core: Read the SD function extension registers for power management To: Ulf Hansson Cc: linux-mmc , Adrian Hunter , Wolfram Sang , Shawn Lin , Avri Altman , Masami Hiramatsu , linux-block , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 4, 2021 at 6:12 PM Ulf Hansson wrote: > In SD spec v4.x the SD function extension registers were introduced. A > specific function register were added to let the card announce support for > optional features in regards to power management. The features that were > added are "Power Off Notification", "Power Down Mode" and "Power > Sustenance". > > As a first step, let's read and parse this register for power management > during the SD card initialization and store the information about the > supported features in the struct mmc_card. In this way, we prepare for > subsequent changes to implement the complete support for the new features. > > Signed-off-by: Ulf Hansson Looks to me like it will work just fine. Reviewed-by: Linus Walleij Yours, Linus Walleij