Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp1340821pxy; Thu, 6 May 2021 06:09:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUZoRw02fL2igSJqQiVLXhhv7/no6lE4y95NPmbq1YUFqXj+GElgP3ChQgk9QqOqPWl+fu X-Received: by 2002:aa7:d413:: with SMTP id z19mr5102727edq.37.1620306585858; Thu, 06 May 2021 06:09:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620306585; cv=none; d=google.com; s=arc-20160816; b=irSMdHRxJS/J+q9FYDyJEVjZT3Mndy/XgEzuBksc8jZuQ0Wcsz+DBoQG2e0+xQIuj0 U/K2h68flAwiX2BwWSMvK2Vdoh+RH68DWTdRBL2wkMrmSz+recYCJXZgCy/1YEPqLRni bZTRcKz+dBCBcm9S4V0li+Lz0mLkVvmEJVasBy0G0eBOpLSXyDEuqlrnoKyymXrzbAw7 JVPrle1tFvryYy8ioX52ulLHKazmkAsTTX6fO7CC66qkL8Yj3v39cuZb42rLXW6RDfnu aXhcYjDJ5n7cLG9XOVjeN02z5g5S9JJzD7DzgVd5sluhouzwneM4SDwYxL2QC5o4tzn1 6x5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=s2qBYSONFf8oTRJo223fI5ppnTybdoSNatNgsyTAANk=; b=NfSvBVvAjEKEUmGj3+uCfxG18tNuRRs7KadRhGx7CFMAwzWhw3vedMVq1bcKV8fBDs eyz2HsOwSDpSoRQTP4fcOJ+ESw3yIZVLZccAsPw1x01yLy6RTrL1pgRO2QCS1ZHOvt64 c+nkZtaBej1uP2M3+DM3k9SyWSPWPj8NeeE7xtTjH2G/2o2KS+IXsc+/pba7lqv1FB7E sGCMuXPs4jkf7fLv3/ceAOYEURo73nwrGMAJLcyo/kEN6FIaYAOySrz+zEfO1kfWwKTX +EsV2p9JAV/tVE8LEIJuJ0+fiNaGq8W9fTrKd10UXkcA3SdnPPBM+8f6TxQcZQYk+POl AGVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wzR7O9Ex; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z8si1623888edd.542.2021.05.06.06.09.21; Thu, 06 May 2021 06:09:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wzR7O9Ex; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229946AbhEFNIZ (ORCPT + 99 others); Thu, 6 May 2021 09:08:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231265AbhEFNIZ (ORCPT ); Thu, 6 May 2021 09:08:25 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91379C061761 for ; Thu, 6 May 2021 06:07:25 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id z9so7660245lfu.8 for ; Thu, 06 May 2021 06:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s2qBYSONFf8oTRJo223fI5ppnTybdoSNatNgsyTAANk=; b=wzR7O9Exm5PyYdlIe1FDgrFDOr7hTDVS5QgTbB/j/KdTpFChF+64xKDQKoeSzmLEXd aoUjjdo5oWzzvhRJL2ODcKYh6BZsfPS0F4vKyQsp1quojhNXr1NAKdTVhsoxqq5teYSx JSCx4BUpHHEvEwrUoJAZ/8SxbbBsxk6NUjSSV6d//jA38yW8fcC9WR/TMs1Z5+TCb9fp DrKauYDjG/ZqXZ/+LYI8t8l+7pcsNP+HXtFVJ8vJ6oS/Y8N1snz+WlOQTEdKRpqwWvZL QhNm1X1cPxPjXKe1MISIU1EY3YU/oEUMCVgjH6yuttYvn0TbeDaW9lB/fF2+EAIHSHV9 bZYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s2qBYSONFf8oTRJo223fI5ppnTybdoSNatNgsyTAANk=; b=JHgIEqclDPgAJQVXFier2D15IajBHVagAhhWUE/ocgCFAbPOfVGQg0HnbksDuYBS0b xEKb39K8vm8/AWocEUAMlbvSzzny9bPn9eKNcLj5ig8w5iqjpcVwp5GWaumkWCO6hj/d iCW1xltHdUY3se0SMMvdI9Uk441YZ72Pc+xKwov6lWsaaVpWcXUeS7njduUnCs3CBUHJ 0UxH6qfjAwuDvz3120WkHWSZW3hKdgsDZt9sEiLfC+EsM7/5VWEWnFN3fHlQiYLCCQWw WU+kASG8DDuH0d/ALHtu79K+aR5MvYEhOondd7ZKGhvCQfXx3gZjhnVmHYNi7S8rhOas zoPg== X-Gm-Message-State: AOAM533qz/6SvkZiiJet+hD2ScETrU347plCpHWtvgGvNPG3wyYDGSrw 5JyDZDjSr/Tu+VziQinZthL71fSYe89flxWxv6/JoQ== X-Received: by 2002:a19:a418:: with SMTP id q24mr2720790lfc.649.1620306444116; Thu, 06 May 2021 06:07:24 -0700 (PDT) MIME-Version: 1.0 References: <20210504161222.101536-1-ulf.hansson@linaro.org> <20210504161222.101536-12-ulf.hansson@linaro.org> In-Reply-To: <20210504161222.101536-12-ulf.hansson@linaro.org> From: Linus Walleij Date: Thu, 6 May 2021 15:07:12 +0200 Message-ID: Subject: Re: [PATCH 11/11] mmc: core: Add support for Power Off Notification for SD cards To: Ulf Hansson Cc: linux-mmc , Adrian Hunter , Wolfram Sang , Shawn Lin , Avri Altman , Masami Hiramatsu , linux-block , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 4, 2021 at 6:12 PM Ulf Hansson wrote: > Rather than only deselecting the SD card via a CMD7, before we cut power to > it at system suspend, at runtime suspend or at shutdown, let's add support > for a graceful power off sequence via enabling the SD Power Off > Notification feature. > > Note that, the Power Off Notification feature was added in the SD spec > v4.x, which is several years ago. However, it's still a bit unclear how > often the SD card vendors decides to implement support for it. To validate > these changes a Sandisk Extreme PRO A2 64GB has been used, which seems to > work nicely. > > Signed-off-by: Ulf Hansson Given how these things work in some quarters I would not be surprised if some SD card vendors tend to start to implement this when they see that Linux (Android) has started to support it. So let's encourage them: Reviewed-by: Linus Walleij Yours, Linus Walleij