Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 6 May 2021 18:06:55 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Dmitry Vyukov <dvyukov@google.com>
Cc:     Uladzislau Rezki <urezki@gmail.com>,
        USB list <linux-usb@vger.kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: [syzbot] WARNING in __vmalloc_node_range
Message-ID: <20210506150655.GD1955@kadam>
References: <000000000000fdc0be05c1a6d68f@google.com>
 <20210506142210.GA37570@pc638.lan>
 <20210506145722.GC1955@kadam>
 <CACT4Y+bEpri=MaveEOSeGGa3i-hwVgt3Cq13GMQxPLWu7g+ThA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACT4Y+bEpri=MaveEOSeGGa3i-hwVgt3Cq13GMQxPLWu7g+ThA@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Thu, May 06, 2021 at 05:00:41PM +0200, 'Dmitry Vyukov' via syzkaller-bugs wrote:
> On Thu, May 6, 2021 at 4:57 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > On Thu, May 06, 2021 at 04:22:10PM +0200, Uladzislau Rezki wrote:
> > > Seems like vmalloc() is called with zero size passed:
> > >
> > > <snip>
> > > void *__vmalloc_node_range(unsigned long size, unsigned long align,
> > >                       unsigned long start, unsigned long end, gfp_t gfp_mask,
> > >                       pgprot_t prot, unsigned long vm_flags, int node,
> > >                       const void *caller)
> > > {
> > >       struct vm_struct *area;
> > >       void *addr;
> > >       unsigned long real_size = size;
> > >       unsigned long real_align = align;
> > >       unsigned int shift = PAGE_SHIFT;
> > >
> > > 2873  if (WARN_ON_ONCE(!size))
> > >               return NULL;
> > > <snip>
> > >
> > > from the dvb_dmx_init() driver:
> > >
> > > <snip>
> > > int dvb_dmx_init(struct dvb_demux *dvbdemux)
> > > {
> > >       int i;
> > >       struct dmx_demux *dmx = &dvbdemux->dmx;
> > >
> > >       dvbdemux->cnt_storage = NULL;
> > >       dvbdemux->users = 0;
> > > 1251  dvbdemux->filter = vmalloc(array_size(sizeof(struct dvb_demux_filter),
> > > <snip>                                              dvbdemux->filternum));
> >
> > Indeed.
> >
> > It is a mystery because array_size() should never return less than
> > sizeof(struct dvb_demux_filter).  That's the whole point of the
> > array_size() function is that it returns ULONG_MAX if there is an
> > integer overflow.
> 
> But it will return 0 if dvbdemux->filternum==0, right?
> 

Heh...  I'm an idiot.  I was thinking of struct_size().  Sorry.

regards,
dan carpenter