Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751115AbWJVQCW (ORCPT ); Sun, 22 Oct 2006 12:02:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751120AbWJVQCV (ORCPT ); Sun, 22 Oct 2006 12:02:21 -0400 Received: from nf-out-0910.google.com ([64.233.182.185]:50847 "EHLO nf-out-0910.google.com") by vger.kernel.org with ESMTP id S1751115AbWJVQCV (ORCPT ); Sun, 22 Oct 2006 12:02:21 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=jQJja0CTO07bdCiCgjwDcJlSsYVX0cRGStgSA079AvPrA2Kxj4uzBwjFnO/AG41aSsIBi7eQooTNRK4FpOXM0hDby6OHBWEzLJ/EEOREF6+AweEmV/hhI06H24ddlvGTjpJvaXWfQx2JQMysdOmpXjnB2DTXGpV6c5roudgpCNI= Message-ID: <86802c440610220902q648a7fc8p38fd9a3391f5bc5d@mail.gmail.com> Date: Sun, 22 Oct 2006 09:02:19 -0700 From: yhlu To: "Muli Ben-Yehuda" Subject: Re: [PATCH] x86-64: typo in __assign_irq_vector when updating pos for vector and offset Cc: "Eric W. Biederman" , "Linux Kernel Mailing List" , "Andi Kleen" In-Reply-To: <20061022085036.GP5211@rhun.haifa.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200610212100.k9LL0GtC018787@hera.kernel.org> <20061022035109.GM5211@rhun.haifa.ibm.com> <86802c440610220128v2e103912sbfba193484fb6304@mail.gmail.com> <20061022085036.GP5211@rhun.haifa.ibm.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1477 Lines: 44 You must have NR_CPUS=4. Also you genapic is running on flat. (logical) Can you try to set NR_CPUS=8 and without this patch? YH On 10/22/06, Muli Ben-Yehuda wrote: > On Sun, Oct 22, 2006 at 01:28:03AM -0700, Yinghai Lu wrote: > > On 10/21/06, Muli Ben-Yehuda wrote: > > >> > > >> typo with cpu instead of new_cpu > > > > > >This patch breaks my x366 machine: > > > > > >aic94xx: device 0000:01:02.0: SAS addr 5005076a0112df00, PCBA SN , 8 phys, > > >8 enabled phys, flash present, BIOS build 1323 > > >aic94xx: couldn't get irq 25 for 0000:01:02.0 > > >ACPI: PCI interrupt for device 0000:01:02.0 disabled > > >aic94xx: probe of 0000:01:02.0 failed with error -38 > > > > > >Reverting it allows it to boot again. Since the patch is "obviously > > >correct", it must be uncovering some other problem with the genirq > > >code. > > > > > > > can you try attached patch? it use cpu_online_map instead of 0xff. > > Works! > > Thanks, > Muli > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/