Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210428175503.3692090-1-clabbe@baylibre.com>
In-Reply-To: <20210428175503.3692090-1-clabbe@baylibre.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 6 May 2021 12:26:32 +0200
Message-ID: <CACRpkdY43=Uh+EVSOPHqNgrhVfgpubZNtXRzO5nW335R6aJGbg@mail.gmail.com>
Subject: Re: [PATCH] ARM: dts: gemini: rename to nand-controller
To:     Corentin Labbe <clabbe@baylibre.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Hans Ulli Kroll <ulli.kroll@googlemail.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Apr 28, 2021 at 7:55 PM Corentin Labbe <clabbe@baylibre.com> wrote:

> We must use nand-controller instead of flash.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Hm, this flash memory isn't NAND, it is just memory-mapped
NOR flash.

The example for CFI NOR flash in
Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
clearly uses the node name "flash@"

There is however a real NAND and serial flash memory
controller at 0x65000000, but I haven't seen a platform
that uses it.

The extra compatible string "cortina,gemini-flash"
turns on some Gemini-specific checks, but it
goes into the global system controller, not the NAND
controller, as the system controller confusingly have
some registers for detecting NOR memory config.
drivers/mtd/maps/physmap-gemini.c

Yours,
Linus Walleij