Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp1624740pxy; Thu, 6 May 2021 11:43:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYDQTpfFJMBLoxK5N8YZCMMxI4nA4jTcF0ezkbiphwI/YisSUTBSIir4RYZ3Fhr8OI7Wl/ X-Received: by 2002:a17:902:ed97:b029:ee:af8e:3a0a with SMTP id e23-20020a170902ed97b02900eeaf8e3a0amr6235433plj.52.1620326607683; Thu, 06 May 2021 11:43:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620326607; cv=none; d=google.com; s=arc-20160816; b=0NFSOA61Dia+IFUMMsfJDSOeApD/uLRV6f1GiuEBEZxcEuNIuIkh+arBn85E2TqE6i Yo6YFYddf4z8Bumejc6r1GkKYJhcUO1YemfdhWutOS7n+dXgLaT3u1VkmBycx0Mv01by L7D4DldOg3SRc0JXI03bPajvP+ZZQtmkfyH+tOTVbaPcljZcT2VOfRmLbzobyQpUw0Nd vXs+G9urS1a1xQhlMjB83mBFo1CzG9cC+gTa6Qrn1xVjmCAVlxZrapfre+do8RRZVcPn vlRnsXO95NwzYR9XPtiSt160gSNgy1/vc2XPtxvXN6sz0BpdP3+AEHPkN5o2ZH3dSX+k p3jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=h9tWSVGqAxyrmuhU0qEueft/17Ve4hq5jQObsYsqKAo=; b=IWHQ3cs5KJBKnTbswGlOE3ITQ0HaB1bJcmbmvmHV5xIwwSh7Cvou3TPd/oKG4x40OH cPGQz7lHEFR8Vl/4DwcEBrIE+WKQ+kYe0NsC1et96sXkBQVf7jrNcNICwFSAj8tnzsSR DBWzy9chLnqNFXy4vvls1vZCG8ZndJyTCnGzfgVOfu5gfTPTtqIUS6BPmsuzYI+znZpv M+ZdzT5TLCDY6SIKukiPjmpxjRZZf1zOcWwpiQraHyqoQs7j7mtpSef6XJFrPTeS+O/M Ep7BmfQkfehLOA5USRCz5KIdIEJvd0HCHQfaPvOrJBX3AQbX2Et4uljxj7c2fqMF7Gml e9LQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kDtQg2xd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x29si4244112pge.495.2021.05.06.11.43.14; Thu, 06 May 2021 11:43:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kDtQg2xd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230130AbhEFM6U (ORCPT + 99 others); Thu, 6 May 2021 08:58:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232296AbhEFM6T (ORCPT ); Thu, 6 May 2021 08:58:19 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47303C061763 for ; Thu, 6 May 2021 05:57:21 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id w15so6895180ljo.10 for ; Thu, 06 May 2021 05:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h9tWSVGqAxyrmuhU0qEueft/17Ve4hq5jQObsYsqKAo=; b=kDtQg2xdKGkWOf0VeyihTIH8uqxMlaYNjyGMUGrtha6n1HTfjcr8AzrA0yAwBaJk65 tj2MF4ZHSAKqplZKiv1MnEkn49gLYQOwBvbwHIe3762SW3NODwUlqxgVS9mvXY2tzCSx Caex0Q17aEZWe65Wf69eLMsbY8pkM6FwNlRbuXZDqz4tJy39IXhQ8ucLS0hkbAEG7/lZ 4X3+zxj3+Mgd58oIwRsoflsZGmZkfJ3LXXTmax8mke3qVjuqvpaOoBCjRzxVSvbuySs9 kujqmiUUv9s3mPhxlPXQgaWFBX7A6pL/OXi0XPYZj+QWzuBlCNeNN9Mvh9L1D+0ZYqaj yBoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h9tWSVGqAxyrmuhU0qEueft/17Ve4hq5jQObsYsqKAo=; b=dD4AECXe/yaDtv2aKWntZvfPYtKN/HHIkkbykm40uD8iMxzX36mkrWdr1+AoKHH7BM ogl87xXngi2btmGbMs8vMm+iYz9JB/zqQoUTB6k4Ic8rRgJcNcZVGWnfZlJineyzgAGF ISl60DPg4k8J8VwbUS4GXyUMK+oANK5IAA1c6i2HpAW1CAM0nWcSRzHmgwhLNqMWja97 3tAuBVLHB+wVpN7QNIhTpjOXM96nxfEjm42UVqQRL2tQlqbyBDCFURy/TiEhAZNESksw GqhKX44wAcfV+w9uF7d4vjV84BrPcOwlZvxhe0VXfIobfj49RYdS+iCCG5VsEFocibbh vIPg== X-Gm-Message-State: AOAM5308MjsTNykxzlmGTpy25J6ORJ+FpE5YfT4XpNpZZCxDv5H2f9CA vE39snaE4tVDB6hSa5QDFqwQpLnrYlbcp3JVStqCcQ== X-Received: by 2002:a2e:81d0:: with SMTP id s16mr3396554ljg.74.1620305839834; Thu, 06 May 2021 05:57:19 -0700 (PDT) MIME-Version: 1.0 References: <20210504161222.101536-1-ulf.hansson@linaro.org> <20210504161222.101536-8-ulf.hansson@linaro.org> In-Reply-To: <20210504161222.101536-8-ulf.hansson@linaro.org> From: Linus Walleij Date: Thu, 6 May 2021 14:57:08 +0200 Message-ID: Subject: Re: [PATCH 07/11] mmc: core: Drop open coding in mmc_sd_switch() To: Ulf Hansson Cc: linux-mmc , Adrian Hunter , Wolfram Sang , Shawn Lin , Avri Altman , Masami Hiramatsu , linux-block , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 4, 2021 at 6:12 PM Ulf Hansson wrote: > The SD_SWITCH (CMD6) is an ADTC type of command with an R1 response, which > can be sent by using the mmc_send_adtc_data(). Let's do that and drop the > open coding in mmc_sd_switch(). > > Signed-off-by: Ulf Hansson Reviewed-by: Linus Walleij Yours, Linus Walleij