Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ib_srpt: Remove redundant assignment to ret
To:     Leon Romanovsky <leon@kernel.org>,
        Yang Li <yang.lee@linux.alibaba.com>
Cc:     dledford@redhat.com, jgg@ziepe.ca, nathan@kernel.org,
        ndesaulniers@google.com, linux-rdma@vger.kernel.org,
        target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
        clang-built-linux@googlegroups.com
References: <1620296105-121964-1-git-send-email-yang.lee@linux.alibaba.com>
 <YJPUQkQCS86mS9gw@unreal>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <b67909dc-c5d6-a8ce-5bea-36b1c7a2b04b@acm.org>
Date:   Thu, 6 May 2021 08:13:05 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <YJPUQkQCS86mS9gw@unreal>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/6/21 4:34 AM, Leon Romanovsky wrote:
> On Thu, May 06, 2021 at 06:15:05PM +0800, Yang Li wrote:
>> Variable 'ret' is set to -ENOMEM but this value is never read as it is
>> overwritten with a new value later on, hence it is a redundant
>> assignment and can be removed
>>
>> In 'commit b79fafac70fc ("target: make queue_tm_rsp() return void")'
>> srpt_queue_response() has been changed to return void, so after "goto
>> out", there is no need to return ret.
>>
>> Clean up the following clang-analyzer warning:
>>
>> drivers/infiniband/ulp/srpt/ib_srpt.c:2860:3: warning: Value stored to
>> 'ret' is never read [clang-analyzer-deadcode.DeadStores]
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
>>  drivers/infiniband/ulp/srpt/ib_srpt.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
> 
> Fixes: b99f8e4d7bcd ("IB/srpt: convert to the generic RDMA READ/WRITE API") 
> 
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

Reverting commit b99f8e4d7bcd and handling queue_*_rsp() errors in the
LIO core probably would be a better approach. Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>