Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp1659618pxy; Thu, 6 May 2021 12:34:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBv2Vr4tfiN8IA2fxBcx4+Ukk9iHDme2xAUAsVI9Z+Q1lYLM+pyTDf9fMi0LAyh7Nru1Cw X-Received: by 2002:a63:d50c:: with SMTP id c12mr6006849pgg.145.1620329660683; Thu, 06 May 2021 12:34:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620329660; cv=none; d=google.com; s=arc-20160816; b=vD63fLqdzi1PCHl92g04CCo2sx6aSIVf8LzcZ2DoaOxUem7U8y2LY7t+9pWO5CgxBx joBkNJvdjtGQSogKPmpxuHxJpyyQLZTRXeSwu/sGEGmnQJ0l+spgNc8khMdjcOIseXY3 qqktglOeRzRYhixvfhKXNPJhIppgp3BAYKE+dIRL5DYtSNUTpsRszHlCaoMcqHdAX1JZ oX0JlppnCuj9jr8DByqWDYZjh138FQpxySDWnp3+1LU+qNQdOhqgc6ROzl6bkKnhdszj xE/ASI0+S1annROmoijljLSOid1nIP0GK/hpoWJxgnObfMNvTEnnic8Z1cVrGwidYYwV j85w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=1Q5dNTrCJtGTUnFAAF/YqMlKgi3nzHaqE59ClaKI744=; b=CEKihGZyGJaOQvq7Z2uCpiJfyQyhXK9+XNDLCtCMKHqUj8J6dCUxsMS6prG/h5Ednb UBaTzH514T+Qa82y1NzuMzNH3WyrRhQ/J8injJEPXj2PdlomOUjo1PJngh7iyr2d2vpQ NoMzdkHy7qimoBc5nlideSSFVp0XRmRNzfGAXvRuim8ZdbahWYyIKQ2gtR26sojNGaRV s1dqUVNv33SmDDTD0IvKceddW8Hcii2rCsuCqf8LGabH/zbRxeqNkUqJRICm7f5KaOqn GzRp1IdcFCbfzl07lkNxb2fHDX3q0qInr3s84cXWK0+ve57mZYUjaLjze/p9xiLukPEn Gb4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j6si3789395pgq.283.2021.05.06.12.34.07; Thu, 06 May 2021 12:34:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235815AbhEFQJb (ORCPT + 99 others); Thu, 6 May 2021 12:09:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235176AbhEFQJa (ORCPT ); Thu, 6 May 2021 12:09:30 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24D33C061761 for ; Thu, 6 May 2021 09:08:32 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1legY7-0002z8-8C; Thu, 06 May 2021 18:08:27 +0200 Message-ID: <7900502879b346e18727f956965ace34a146c0f1.camel@pengutronix.de> Subject: Re: [RESEND v4 1/2] dt-bindings: imx6q-pcie: add one regulator used to power up pcie phy From: Lucas Stach To: lorenzo.pieralisi@arm.com Cc: linux-pci@vger.kernel.org, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Richard Zhu , andrew.smirnov@gmail.com, shawnguo@kernel.org, kw@linux.com, bhelgaas@google.com, stefan@agner.ch Date: Thu, 06 May 2021 18:08:24 +0200 In-Reply-To: <1617091701-6444-2-git-send-email-hongxing.zhu@nxp.com> References: <1617091701-6444-1-git-send-email-hongxing.zhu@nxp.com> <1617091701-6444-2-git-send-email-hongxing.zhu@nxp.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lorenzo, have those two patches fallen through some crack? AFAICS they are gone from patchwork, but I also can't find them in any branch in the usual git repos. Regards, Lucas Am Dienstag, dem 30.03.2021 um 16:08 +0800 schrieb Richard Zhu: > Both 1.8v and 3.3v power supplies can be used by i.MX8MQ PCIe PHY. > In default, the PCIE_VPH voltage is suggested to be 1.8v refer to data > sheet. When PCIE_VPH is supplied by 3.3v in the HW schematic design, > the VREG_BYPASS bits of GPR registers should be cleared from default > value 1b'1 to 1b'0. Thus, the internal 3v3 to 1v8 translator would be > turned on. > > Signed-off-by: Richard Zhu > Reviewed-by: Lucas Stach > --- >  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 3 +++ >  1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > index de4b2baf91e8..d8971ab99274 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > @@ -38,6 +38,9 @@ Optional properties: >    The regulator will be enabled when initializing the PCIe host and >    disabled either as part of the init process or when shutting down the >    host. > +- vph-supply: Should specify the regulator in charge of VPH one of the three > + PCIe PHY powers. This regulator can be supplied by both 1.8v and 3.3v voltage > + supplies. >   > >  Additional required properties for imx6sx-pcie: >  - clock names: Must include the following additional entries: