Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775AbWJVRmr (ORCPT ); Sun, 22 Oct 2006 13:42:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751321AbWJVRmr (ORCPT ); Sun, 22 Oct 2006 13:42:47 -0400 Received: from pne-smtpout2-sn2.hy.skanova.net ([81.228.8.164]:46311 "EHLO pne-smtpout2-sn2.hy.skanova.net") by vger.kernel.org with ESMTP id S1751775AbWJVRmq (ORCPT ); Sun, 22 Oct 2006 13:42:46 -0400 To: balagi@justmail.de Cc: linux-kernel@vger.kernel.org, akpm@osdl.org Subject: Re: [PATCH] 2.6.19-rc2-mm2 pktcdvd: add sysfs and debugfs interface References: From: Peter Osterlund Date: 22 Oct 2006 19:42:34 +0200 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1089 Lines: 23 "Thomas Maier" writes: > this patch adds a sysfs and debugfs interface > to the pktcdvd driver. > The procfs interface is not modified! Calling the character device interface "procfs interface" is misleading, so I disagree with this part of the patch: + Note: pktsetup uses the pktcdvd procfs interface! The only connection pktsetup has with procfs is that it reads the character device minor number from /proc/misc. If that number was available somewhere else or if udev created /dev/pktcdvd/control automatically, pktsetup wouldn't need /proc at all. Actually, checking my FC5 installation, /dev/pktcdvd/control is created automatically when the driver is loaded, so the /proc code in pktsetup is only needed to cope with older distributions. -- Peter Osterlund - petero2@telia.com http://web.telia.com/~u89404340 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/