Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp1672613pxy; Thu, 6 May 2021 12:56:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPGhb+V6mGpk+1E2UAgcCNrCE2HAnS6X7u/x2n4aYaZj32wcDzYuQguw3Ns3evf0RqU8d4 X-Received: by 2002:a62:7b8d:0:b029:28b:a5c1:7847 with SMTP id w135-20020a627b8d0000b029028ba5c17847mr6596307pfc.27.1620330986568; Thu, 06 May 2021 12:56:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620330986; cv=none; d=google.com; s=arc-20160816; b=l6aE21qwvCjx6G9BsFqoEBegXr1j4ey0aELc3TXMlJ3fPpC9T6xUlbOrh2uZdAj6Kb o36Zos79E8TcgLx2NKJOHWhTxIajHyAYz7YDgIzrBfJSJqAqRa7wd1N5NZCpdoZOVIsN HCTg5UE4wgS/5eyruAtcWwRjMp3hFqNJG9w6nofiliP/JRPe3zKEtINTIsbJb7Xf0AUF 1yB3d46Eg9JUE2B/IpF8wqn7NzkhTQVBV1oc+2SN1kyDh9vnUvf6FjrYjLWeLV2c+BSp 7aFW+qr7fXiNy5kyHCAR5Ig4Uf9NsNHuMAHDa7Z/k53As+IRg1pz51EU3SCmNanUr7pf ieuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iWTrcWevnKSgcsLU0ifwZpMW/1cu+iXYgU6D9tyHUgc=; b=p1v+RyOqXPFS6aQAa3MKvOYrYLapgyAr2zLmx0m6szKfBj94a6sXSkzyZQvbvWE10N HUr3Tj2ehpB6+DmXpbO4M2kB2mNoGJ6C9dzcDYCiyrztcqrcQhnSkBX3DD3fs8KQOvlD tpbbQFofqF7PJQbEaqut2Zt9BBsa/1hGkMn3L98hatNFqDzq3ECCDw+SC/G//qepvROf SEY4msAbEXY9pUjZyBcQV3Evhg0TiscAnvSdUZ7UNNN+g5HHdcNZqYQmnpwEcMzgE7Qj aFdzpmhf7qP3TUNYohwlEbv1uQAu++G/MFjsMZ5+qvpx7BA7aJh4p5Ds4CD+WQlhJa+Q /K0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GYgkzkye; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id iq22si12566222pjb.25.2021.05.06.12.56.14; Thu, 06 May 2021 12:56:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GYgkzkye; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234941AbhEFTOv (ORCPT + 99 others); Thu, 6 May 2021 15:14:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:40144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234467AbhEFTOu (ORCPT ); Thu, 6 May 2021 15:14:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 63B3C61107; Thu, 6 May 2021 19:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620328431; bh=Xd/ndCtgZJ2dO4cS5u02uHTb6AeNYHoi+rl86LUAbso=; h=From:To:Cc:Subject:Date:From; b=GYgkzkyezQq25+wnQeXre7srZxxQyVeHIWgdt+aJ9BwHucvGsxj8IqBFxcABjkdyf fTSQFXtZHhvZeevvP/MtiPeAZS7gaZK/9Hw2zF5fSRcQmrNLVYUs2w7hBeWQcNvDV6 699A6NY5iSs56tuPkLBWjPVv/ikWYjzSIyrlTQEMsedhHv1sS8KAGlaDS3zOx6FB0J AurGdOsFF+ZI332T8HAT4lt4Wjn5INvv/eR8PDtB8yc3odCV0EuSuLP+HkZE+v6Z4O 6mp9SKlDDkUVOM8EMd2Kv+8bvhef2RN6t/afdelMtddteKTSjucLS5ojIpNr4Fjaz3 q8qiVhYbYmA7A== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH] f2fs: return -EPERM given generic mask Date: Thu, 6 May 2021 12:13:47 -0700 Message-Id: <20210506191347.1242802-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.31.1.607.g51e8a6a459-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In f2fs_fileattr_set(), if (!fa->flags_valid) mask &= FS_COMMON_FL; In this case, we should not allow to set FS_COMPR_FL, instead of BUG_ON. /* Flags shared betwen flags/xflags */ (FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \ FS_NODUMP_FL | FS_NOATIME_FL | FS_DAX_FL | \ FS_PROJINHERIT_FL) Fixes: 4c5b47997521 ("vfs: add fileattr ops") Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index e01ce802cf10..38015ef84893 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1817,7 +1817,9 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) struct f2fs_inode_info *fi = F2FS_I(inode); u32 masked_flags = fi->i_flags & mask; - f2fs_bug_on(F2FS_I_SB(inode), (iflags & ~mask)); + /* mask can be shrunk by flags_valid selector */ + if (iflags & ~mask) + return -EPERM; /* Is it quota file? Do not allow user to mess with it */ if (IS_NOQUOTA(inode)) -- 2.31.1.607.g51e8a6a459-goog