Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp1682966pxy; Thu, 6 May 2021 13:11:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysvweCNRNxigUzlsxPD+dY+geGBvrKAQjmOO8FakVRlsPKeM3U8Kj8yweFgtmnacxGO4+K X-Received: by 2002:a17:906:7fd2:: with SMTP id r18mr2576929ejs.78.1620331884382; Thu, 06 May 2021 13:11:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620331884; cv=none; d=google.com; s=arc-20160816; b=e/ArPd03hYTKvZPK7olDXvz968MotLm8/RYm3FatrVtUQQ/035TOiRCJuUnX1iQ6AW A0lVzq/FpIbwszlecTyydLGDcm3bOICWZ/bx5PH3WJ95h0eyxeqHCw/n0XykN2LtMjIA 5CLY/zwbFMjlcBMXAJAD6il8xemq2EH8Jzhve1o8f7b2hcD3WR8poUI6TPV1kQVpSB69 LOpXWZ+1xETFE9ap6qPZQ1ryP3QTyLQVAWyLladKvAQtPJ14S+FevzSOLtXblvP03grG i6nEAGsUUlMaKhN7z5gRUnYYDxu82Xd/SAMjp0JA/U2LBDnTGq1lz0gvZB3sZhIeEnDC ezuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id:dkim-signature; bh=hhyxUtgR+B7x+kVwQUha59XgAwJqFT7lXBFEsYsowC8=; b=eDvVG9pFsT/KQH4L5y+azdLi4O+LASCpFxXsCcgEfPOBBYQh628szfAYap4MT9yXkE S3HNwmkjK7cYumMK3qksDhxZ8kcqKMLxh7O4pitOc+S/KKmmhT5x8ySkYlT6tOIVQB2f wAwzpgOTe2h9ggfTPbloMlVRy/vqKVcx6/1tqnLRPS7fcv2pyUWFI5wgjkWJO2Dp2Ul4 zKD2KMfp/zDyyIqRy3f8MwvbWcI3DbIioZ+JFkMuGSt0W5wmA71NE3c0HjYSKZi2srno uVjgsOKyOd3xKKbg6f9wvDL2cRfF56STcZdtuzuUZrMmC+Um+F6E3XYLVFqX+VSUoo/p OKgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=FYz67lt2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bo2si3389182ejb.202.2021.05.06.13.10.53; Thu, 06 May 2021 13:11:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=FYz67lt2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235675AbhEFTnw (ORCPT + 99 others); Thu, 6 May 2021 15:43:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235628AbhEFTnu (ORCPT ); Thu, 6 May 2021 15:43:50 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD0DDC061761 for ; Thu, 6 May 2021 12:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=hhyxUtgR+B7x+kVwQUha59XgAwJqFT7lXBFEsYsowC8=; b=FYz67lt2uLfSCElARaIMcxCp52 mN05C2AkGfg/3XYibjBpK/EFm4bU+Pu+kXcXuJ5XIDVQI5xAi3S6EXsMVMjGlQlPp2FEWLwxScY7u lAByljCmH2241f3eWr0jjyi1AyGWuFFJJJ9PC0TtFjvwIJyyQyxgRkUS4rg2eSVArz/iMtbvPvj2t 7rn5FwOU06CywuH2DVeiZxKUfOd8gFgxXQtXhWuFIeJW7uhOdSxqofAo11nUYlSbjHs+aOTBfl/GI +a+wccHgoNLCuTHlmubkIRMAVqXfw67i+tSvQeWPl1AfCtKKo4ONzkuZBfJ91o1l7Gev7CCQ3/C+v Yw6wQbkg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lejtT-005BM8-8s; Thu, 06 May 2021 19:42:43 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 25C6A300365; Thu, 6 May 2021 21:42:39 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id C8FC820B96F91; Thu, 6 May 2021 21:42:38 +0200 (CEST) Message-ID: <20210506194158.091028792@infradead.org> User-Agent: quilt/0.66 Date: Thu, 06 May 2021 21:34:03 +0200 From: Peter Zijlstra To: x86@kernel.org, jpoimboe@redhat.com, jbaron@akamai.com, rostedt@goodmis.org, ardb@kernel.org Cc: linux-kernel@vger.kernel.org, peterz@infradead.org Subject: [PATCH 11/13] objtool: Rewrite jump_label instructions References: <20210506193352.719596001@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When a jump_entry::key has bit1 set, rewrite the instruction to be a NOP. This allows the compiler/assembler to emit JMP (and thus decide on which encoding to use). Signed-off-by: Peter Zijlstra (Intel) --- tools/objtool/check.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1223,6 +1223,20 @@ static int handle_jump_alt(struct objtoo return -1; } + if (special_alt->key_addend & 2) { + struct reloc *reloc = insn_reloc(file, orig_insn); + + if (reloc) { + reloc->type = R_NONE; + elf_write_reloc(file->elf, reloc); + } + elf_write_insn(file->elf, orig_insn->sec, + orig_insn->offset, orig_insn->len, + arch_nop_insn(orig_insn->len)); + orig_insn->type = INSN_NOP; + return 0; + } + *new_insn = list_next_entry(orig_insn, list); return 0; }