Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210506193726.45118-1-luca.stefani.ge1@gmail.com>
In-Reply-To: <20210506193726.45118-1-luca.stefani.ge1@gmail.com>
From:   Todd Kjos <tkjos@google.com>
Date:   Thu, 6 May 2021 12:53:45 -0700
Message-ID: <CAHRSSEz3=xUwFay0coYv+xC8xi54kAJkkTUOMYfotAV_AEQ00g@mail.gmail.com>
Subject: Re: [PATCH] binder: Return EFAULT if we fail BINDER_ENABLE_ONEWAY_SPAM_DETECTION
To:     Luca Stefani <luca.stefani.ge1@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        Todd Kjos <tkjos@android.com>,
        Martijn Coenen <maco@android.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Christian Brauner <christian@brauner.io>,
        Hridya Valsaraju <hridya@google.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Hang Lu <hangl@codeaurora.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, May 6, 2021 at 12:37 PM Luca Stefani <luca.stefani.ge1@gmail.com> wrote:
>
> All the other ioctl paths return EFAULT in case the
> copy_from_user/copy_to_user call fails, make oneway spam detection
> follow the same paradigm.
>
> Fixes: a7dc1e6f99df ("binder: tell userspace to dump current backtrace
> when detected oneway spamming")
> Signed-off-by: Luca Stefani <luca.stefani.ge1@gmail.com>

Acked-by: Todd Kjos <tkjos@google.com>

> ---
>  drivers/android/binder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 61d34e1dc59c..bcec598b89f2 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -4918,7 +4918,7 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>                 uint32_t enable;
>
>                 if (copy_from_user(&enable, ubuf, sizeof(enable))) {
> -                       ret = -EINVAL;
> +                       ret = -EFAULT;
>                         goto err;
>                 }
>                 binder_inner_proc_lock(proc);
> --
> 2.31.1
>