Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp1704878pxy; Thu, 6 May 2021 13:49:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxHR/5XxdymMD/u2tOCXhxBgEodZ8rbFILWTrFsyUvKlhl4bOhAsPe0rM+pECQZvfD8qEz X-Received: by 2002:a62:4d86:0:b029:252:c889:2dd8 with SMTP id a128-20020a624d860000b0290252c8892dd8mr6931065pfb.41.1620334193798; Thu, 06 May 2021 13:49:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620334193; cv=none; d=google.com; s=arc-20160816; b=EhZ1lXs8wZoV5U9Qw3pPezTPIcM53bVnarH3zkGtpeZbgN9iM0EevZKw788mfcIr+J q9KicRgANP/tNdsxsnvv1mWtd15yLkIw+msygbI0pApRacIHpjkj7R1OazQ2/HR4OzG/ UQdnj0ad2593d4y8Lq+B7XzJepCr0Bz+fZ6sd3AMk/bmuzIR8xWDBqOcc4YAuk8rPiml TzG2qgNlpsucGWvue1zNDgqpWAtAUHpdzjeJHF1fz+LfESlxsQTd2Y4oMLpoJQ8jCi46 FrEscIC2ZBMC44RFg68gE+2DQxpuZMSjPoKFkBPEj7kaDaIOtDorIuS8uFTsZwfq84P0 pOSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=CFzCeqjjKd6m6z9WRNZ/hxd41ucLWxrqHIghv0SFnJg=; b=qMIh8B7jCJUy2O12yHHIytMvHRatfoISOBm7MQy8D3Rexnkr5QmJEL2QoL+9G/o+cD zPtAAET5OoRYiScrj6xyZCrgWPhORtKOCe5bWP5PXzN5QFW6rnzllLG5B8SGZcgZvp2M lxPA6JBycAysng+Exd5SuSfqG797pwJK9gxSNfLpTODQQf5TeuGQPtZdiy9Ghn9DEdqL xuCP5w0lLmU1dgyoBljI0lmxjj/Ys50LjrbpSQXdOLD7pOacTTrmj+zAU5Jogi/WnslA 8hp65bA3MLYFtcG3h4cVT2cE8d8yfcLspjTcaAcvtXlPnh1AQRAPir2+kkSXruhdKz5t 1OYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e7si1386207pfi.290.2021.05.06.13.49.15; Thu, 06 May 2021 13:49:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229970AbhEFUrE (ORCPT + 99 others); Thu, 6 May 2021 16:47:04 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:53589 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230104AbhEFUrD (ORCPT ); Thu, 6 May 2021 16:47:03 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d54 with ME id 1Ym32500121Fzsu03Ym3uY; Thu, 06 May 2021 22:46:04 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Thu, 06 May 2021 22:46:04 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: ohad@wizery.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, s-anna@ti.com Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] remoteproc: k3-r5: Fix an error message Date: Thu, 6 May 2021 22:46:01 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'ret' is known to be 0 here. Reorder the code so that the expected error code is printed. Fixes: 6dedbd1d5443 ("remoteproc: k3-r5: Add a remoteproc driver for R5F subsystem") Signed-off-by: Christophe JAILLET --- drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c index 5cf8d030a1f0..4104e4846dbf 100644 --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c @@ -1272,9 +1272,9 @@ static int k3_r5_core_of_init(struct platform_device *pdev) core->tsp = k3_r5_core_of_get_tsp(dev, core->ti_sci); if (IS_ERR(core->tsp)) { + ret = PTR_ERR(core->tsp); dev_err(dev, "failed to construct ti-sci proc control, ret = %d\n", ret); - ret = PTR_ERR(core->tsp); goto err; } -- 2.30.2