Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp1784222pxy; Thu, 6 May 2021 16:11:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBvHwE3YRxLFzWCMTordGbcjyZ+934AoH+h2Ei9NaVdIwrrE5CiXO/xnUz91kvmOYbnIpB X-Received: by 2002:a63:175e:: with SMTP id 30mr6766265pgx.48.1620342719513; Thu, 06 May 2021 16:11:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620342719; cv=none; d=google.com; s=arc-20160816; b=Y4khAtEU6jmIV5iQi/YrH0ftcl/La7qmJ4LoxsH494y7oOLyD/cAQuh3ZZFDlHK+BS meYw/LmHaMIVkdo/B6YYyNIX2sb+w6JFflgt4gR+aGTqt5KJsKImu7UfuG7SWJhDd4Rx MvJxmX9IbFWVAMv7hwySQkRD5EoMNvQwPsayCqo2jFteFyHqOE1A9YimiWBUyJ+uSKT5 OPkR09pFu9niuFzcLt9Y9RfUAReTwrVKga5cRlJWAovpi6ZC23+7eLyIs/ngGaFHALQ9 6U/9AzzplUG40iYQY/L2RBPuanyLcNOhlKsfhR0Orzmo1khSMBNNvrPRC30Q58yaHiRj l8Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :dlp-version:dlp-reaction:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=0uHLuqsOrlsOjNWuv8NuvpialeVZAbgKQ28kRLz6ICg=; b=z2ro3kC4CAfHItoM5jMq52y/fD69mLITl83LJ9b5/+8A9W7QU+x9J9oxDEOSmTeoa/ zlUXcaQ3Ub43cnvAEsCQj2Q+Pkeu9uVTPrPKTA3q9LTe4WKh0st60LKEHQZ2k/aoZ9fM l2UNp0kkKiQNQs8Yb/W5op1ReNlKcbLBlQDy/isQwjTGiFBtasCQlxNYRRJQmfnMDKTi oeZd74ne9+IbHoTVyU0VP5+1+JGw/fORDZag7TuTxoMMuguTZ6QdWOZQMYzbfAFZH/9h fwUDPOtg41JBsJJscZaOC690LgmU5dEY6DO37Oqaza2a3tH8fw0UOmudcTdAe52MWTjq CBHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a6si4795054pgm.17.2021.05.06.16.11.46; Thu, 06 May 2021 16:11:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235903AbhEFPil convert rfc822-to-8bit (ORCPT + 99 others); Thu, 6 May 2021 11:38:41 -0400 Received: from mga01.intel.com ([192.55.52.88]:20964 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235926AbhEFPfu (ORCPT ); Thu, 6 May 2021 11:35:50 -0400 IronPort-SDR: 2jj8juM3HyfoQ45CGoGvoEzkLf7jsJSr1h+b1C9lYP7qA8PTh9YTFuBfJUYYkPV5qzCl+0rvCs uw8XvkoTTUZg== X-IronPort-AV: E=McAfee;i="6200,9189,9976"; a="219384801" X-IronPort-AV: E=Sophos;i="5.82,277,1613462400"; d="scan'208";a="219384801" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2021 08:34:50 -0700 IronPort-SDR: NX6RzwNeSAMDp6StW305M+Sd+j+jLrk4wgWenh2fgUMxfDOGbwPNO5RINx2WwaPChKh//xB+t1 zl9eBy51KnYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,277,1613462400"; d="scan'208";a="407051744" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 06 May 2021 08:34:49 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 6 May 2021 08:34:49 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 6 May 2021 08:34:49 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2106.013; Thu, 6 May 2021 08:34:49 -0700 From: "Luck, Tony" To: Aili Yao , Naoya Horiguchi CC: "linux-mm@kvack.org" , Andrew Morton , Oscar Salvador , "David Hildenbrand" , Borislav Petkov , "Andy Lutomirski" , Naoya Horiguchi , Jue Wang , "linux-kernel@vger.kernel.org" , "yaoaili126@gmail.com" Subject: RE: [PATCH v4 1/2] mm/memory-failure: Use a mutex to avoid memory_failure() races Thread-Topic: [PATCH v4 1/2] mm/memory-failure: Use a mutex to avoid memory_failure() races Thread-Index: AQHXOy7Hy/b3oTVTZEO3lND/F7hluKrWtfmA///ss2A= Date: Thu, 6 May 2021 15:34:48 +0000 Message-ID: References: <20210427062953.2080293-1-nao.horiguchi@gmail.com> <20210427062953.2080293-2-nao.horiguchi@gmail.com> <20210506173757.586580bd@alex-virtual-machine> In-Reply-To: <20210506173757.586580bd@alex-virtual-machine> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Sorry to interrupt, I just thought one thing: > > This mutex seems not been bind to the error page, will there be some core case > like test code or multi-poison case whick will break this mutex? The mutex is a bigger hammer than strictly needed . If there are simultaneous errors on different pages they could, int theory, proceed in parallel. But this mutex will serialize the processing. Is this a problem? Hopefully systems aren't seeing so many uncorrectable/recoverable errors that this would be a significant bottleneck. -Tony