DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=Message-ID:Received:Date:From:Subject:To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=DTG0pn7prCEHGHerAtjOkbznCKewX2rKnf7O1BQn63ux5JzZ7AvQslpyevmGB0303p4vBHZtuzLyKp8oIWu+0sUffcOMfdsDZVUrgrCAlOHfJSFCz78+53g4Q3k4f3wBtP0EXruvO40e6KyN+KBN9rVenu1prj+P2xGj9BLJeQg=  ;
Message-ID: <20061022195809.30126.qmail@web55607.mail.re4.yahoo.com>
Date: Sun, 22 Oct 2006 12:58:08 -0700 (PDT)
From: Amit Choudhary <amit2030@yahoo.com>
Subject: Hopefully, kmalloc() will always succeed, but if it doesn't then....
To: linux-kernel@vger.kernel.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1062
Lines: 44


Hi All,

Hopefully, kmalloc() should always succeed. But if it doesn't then the kernel is going to crash
left and right. But I guess that there's no point in running if there is no memory. Anyways, here
is what I found at many places:

func()
{
   char *a; 
   char *b;

   a = kmalloc(10, GFP_KERNEL);
   if (!a)
       goto error;

   b = kmalloc(10, GFP_KERNEL);
   if (!b)
       goto error;

 error:
  kfree(a);
  kfree(b);

}

So, if memory allocation to 'a' fails, it is going to kfree 'b'. But since 'b' is not initialized,
 kfree may crash (unless DEBUG is defined).

I have seen the same case at many places when allocating in a loop.

Regards,
Amit 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/