Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 6 May 2021 23:33:25 -0700
From:   Eric Biggers <ebiggers@kernel.org>
To:     Chao Yu <yuchao0@huawei.com>
Cc:     jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger
 frequency
Message-ID: <YJTfNeYeDT65GslB@sol.localdomain>
References: <20210425011053.44436-1-yuchao0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210425011053.44436-1-yuchao0@huawei.com>
Precedence: bulk

On Sun, Apr 25, 2021 at 09:10:53AM +0800, Chao Yu wrote:
> +	if (!error && S_ISDIR(inode->i_mode) && f2fs_encrypted_file(inode) &&
> +			f2fs_is_checkpointed_node(sbi, inode->i_ino))
> +		f2fs_add_ino_entry(sbi, inode->i_ino, ENC_DIR_INO);

This will never be true, since S_ISDIR() and f2fs_encrypted_file() are logically
contradictory (as f2fs_encrypted_file() only returns true when S_ISREG()).

How did you test this change?

- Eric