Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp200537pxy; Fri, 7 May 2021 00:56:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuX4UrOnPIjHb5njcH+aR2TYfuiNBdlcA9t6nq/Drhcp+kkRue0uFFNHHuenHP/KZew9VW X-Received: by 2002:aa7:d917:: with SMTP id a23mr9589736edr.260.1620374215369; Fri, 07 May 2021 00:56:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620374215; cv=none; d=google.com; s=arc-20160816; b=LK8r5+Evh25IS5KzvSIEv/MQwHSrmL1vHUnnm+0aHO2obiUett1jYtSrI/QhKF+nAe O6OLerSZZsYOSixecZuyGpEtlXR4pIZ5aArErRRkPfX9p9MeW9Gh2GzXf4EAqDkgGAXM /8zNv9mtuWpuhq+bgfCsKGHzc6zNQY8X+vbOPVl0ZQWWIhk/0/IXk+dUDfcqIk/4FHqW tNp2fvQABhZRSWl8EmpoyryhIA13l6fbIC2xsetUnyWljNUEOgyJUtLZTiBgLdHuCCTx 06+HLqTa+IGDUBWgw+R4QdI3Q1HX7oVkfklY166/1cuuho2JiNkD7PLdatyACQ/nACBx AC8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=szfc7718Ma9+8djyJ+rF4AwxZnEKUYyvat43JY3WNyA=; b=u0cj0KcMloZr40rrUIdbUsxnZxS107ad2NLccVejq7WXXVkH6DwDElGF8I6mdHtyqA QGk7H/31uOle3aGlkmLU6RFN7pRBbqMHS6+Pm8KaLpNlSohT4A1+jxOxBgNTaUVxMdl+ rFmqy1oeAifUvBlS4EjfEfU53UceBzKLTmrVqzBFco1n1GgLJiVjbhLSHa9p9n+ySJL8 aIz26VvugcZaQR75tlWbbTDln8yvBzsdCDa6sbuEz0rtaOvFuUsU65oCv8ysV11FG05C TbZu4t6iWEewnvX+nLAiaXMYkvTvnehQ++nFExcTqsFfJiOiiSBbnX0xU6ugaF+X6Nem skPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s3si4345971edq.457.2021.05.07.00.56.31; Fri, 07 May 2021 00:56:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235208AbhEGHQY (ORCPT + 99 others); Fri, 7 May 2021 03:16:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:38172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232796AbhEGHQX (ORCPT ); Fri, 7 May 2021 03:16:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7D004613D6; Fri, 7 May 2021 07:15:21 +0000 (UTC) Date: Fri, 7 May 2021 09:15:19 +0200 From: Christian Brauner To: Luca Stefani Cc: Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Hridya Valsaraju , Suren Baghdasaryan , Hang Lu , linux-kernel@vger.kernel.org Subject: Re: [PATCH] binder: Return EFAULT if we fail BINDER_ENABLE_ONEWAY_SPAM_DETECTION Message-ID: <20210507071519.et56j3kqcxrhykqo@wittgenstein> References: <20210506193726.45118-1-luca.stefani.ge1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210506193726.45118-1-luca.stefani.ge1@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 06, 2021 at 09:37:25PM +0200, Luca Stefani wrote: > All the other ioctl paths return EFAULT in case the > copy_from_user/copy_to_user call fails, make oneway spam detection > follow the same paradigm. > > Fixes: a7dc1e6f99df ("binder: tell userspace to dump current backtrace > when detected oneway spamming") > Signed-off-by: Luca Stefani > --- Looks good, Acked-by: Christian Brauner