Date: Sun, 22 Oct 2006 23:09:35 +0200 (MEST)
From: Jan Engelhardt <jengelh@linux01.gwdg.de>
To: Pekka Enberg <penberg@cs.helsinki.fi>
cc: Amit Choudhary <amit2030@yahoo.com>, linux-kernel@vger.kernel.org
Subject: Re: Hopefully, kmalloc() will always succeed, but if it doesn't
 then....
In-Reply-To: <84144f020610221322v2683a66bmf837ada1edea72e0@mail.gmail.com>
Message-ID: <Pine.LNX.4.61.0610222306240.22903@yvahk01.tjqt.qr>
References: <20061022195809.30126.qmail@web55607.mail.re4.yahoo.com>
 <84144f020610221322v2683a66bmf837ada1edea72e0@mail.gmail.com>
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="1283855629-1786028654-1161551375=:22903"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1526
Lines: 55

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--1283855629-1786028654-1161551375=:22903
Content-Type: TEXT/PLAIN; charset=UTF-8
Content-Transfer-Encoding: 8BIT


>> So, if memory allocation to 'a' fails, it is going to kfree 'b'. But since
>> 'b'
>> is not initialized, kfree may crash (unless DEBUG is defined).

... in which case we will be notified:

$ cat test.c
#include <linux/slab.h>

void func(void) {
    char *a, *b;
    if((a = kmalloc(10, GFP_KERNEL)) == NULL)
        goto err;
    if((b = kmalloc(10, GFP_KERNEL)) == NULL)
        goto err;

 err:
    kfree(a);
    kfree(b);
    return;
}

$ make -C /erk/kernel/linux-2.6.19-rc2 M=$PWD
  CC [M]  /dev/shm/test.o
/dev/shm/test.c: In function ‘func’:
/dev/shm/test.c:4: warning: ‘b’ may be used uninitialized in this 
function


Compared to the whole source tree, the kernel has very few "may be 
uninitialized" spots. And stochastically, it is quite unlikely that all 
of them are caused by a construct like the above.


>> I have seen the same case at many places when allocating in a loop.
>
> So you found a bug. Why not send a patch to fix it?


	-`J'
-- 
--1283855629-1786028654-1161551375=:22903--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/