Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] video: fbdev: imxfb: Fix an error message
To:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     s.hauer@pengutronix.de, kernel@pengutronix.de, shawnguo@kernel.org,
        festevam@gmail.com, linux-imx@nxp.com, j.beisert@pengutronix.de,
        krzysztof.h1@poczta.fm, linux-fbdev@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org
References: <d7b25026f82659da3c6f7159eea480faa9d738be.1620327302.git.christophe.jaillet@wanadoo.fr>
 <20210507050503.iwrcis2xzhjjthmp@pengutronix.de>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Message-ID: <5cd9c8de-acd9-9594-38a0-62ecf5734c10@wanadoo.fr>
Date:   Fri, 7 May 2021 09:11:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210507050503.iwrcis2xzhjjthmp@pengutronix.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 07/05/2021 ? 07:05, Uwe Kleine-K?nig a ?crit?:
> Hello Christophe,
> 
> On Thu, May 06, 2021 at 08:57:05PM +0200, Christophe JAILLET wrote:
>> 'ret' is known to be 0 here.
>> No error code is available, so just remove it from the error message.
>>
>> Fixes: 72330b0eeefc ("i.MX Framebuffer: Use readl/writel instead of direct pointer deref")
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>>   drivers/video/fbdev/imxfb.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
>> index 7f8debd2da06..ad598257ab38 100644
>> --- a/drivers/video/fbdev/imxfb.c
>> +++ b/drivers/video/fbdev/imxfb.c
>> @@ -992,7 +992,7 @@ static int imxfb_probe(struct platform_device *pdev)
>>   	info->screen_buffer = dma_alloc_wc(&pdev->dev, fbi->map_size,
>>   					   &fbi->map_dma, GFP_KERNEL);
>>   	if (!info->screen_buffer) {
>> -		dev_err(&pdev->dev, "Failed to allocate video RAM: %d\n", ret);
>> +		dev_err(&pdev->dev, "Failed to allocate video RAM\n");
>>   		ret = -ENOMEM;
>>   		goto failed_map;
>>   	}
> 
> Reviewed-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> 
> Are you using this driver, or did you find that problem using some
> static checker?
> 

No, I'm not using this driver AFAIK.

It has been spotted by coccinelle with a hand-made script which tries to 
find places where error code is used before being initialized.

The script in it-self is not really interesting. It is easy to write and 
my own version trigger way to much false positives.

CJ

> Best regards
> Uwe
>