Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CWXP265MB2680DC98B32CD4B49AA8A224C4599@CWXP265MB2680.GBRP265.PROD.OUTLOOK.COM>
 <DM6PR04MB657570DB58E7ABBE2C3B0449FC589@DM6PR04MB6575.namprd04.prod.outlook.com>
 <CWXP265MB2680A8DD0FFA6FECBFDFB027C4579@CWXP265MB2680.GBRP265.PROD.OUTLOOK.COM>
In-Reply-To: <CWXP265MB2680A8DD0FFA6FECBFDFB027C4579@CWXP265MB2680.GBRP265.PROD.OUTLOOK.COM>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Fri, 7 May 2021 13:34:17 +0200
Message-ID: <CAPDyKFqZ580uHgfob5wfn7a_+Y-q3h0YrvirrNYSFT5Q_St2SA@mail.gmail.com>
Subject: Re: [PATCH v2] mmc: block: ioctl: No busywaiting of non-TRAN CMDs
To:     =?UTF-8?Q?Christian_L=C3=B6hle?= <CLoehle@hyperstone.com>
Cc:     Avri Altman <Avri.Altman@wdc.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "zliua@micron.com" <zliua@micron.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 7 May 2021 at 12:34, Christian L=C3=B6hle <CLoehle@hyperstone.com> =
wrote:
>
> Prevent busywaiting for TRAN state indication
> after issuing a command that will not transition
> to TRAN state.
>
> Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
> ---
>  drivers/mmc/core/block.c | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index 689eb9afeeed..48be2ca5e3d1 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -446,6 +446,20 @@ static int card_busy_detect(struct mmc_card *card, u=
nsigned int timeout_ms,
>         return err;
>  }
>
> +static inline bool is_tran_transition_cmd(struct mmc_command *cmd,
> +                                         struct mmc_card *card)
> +{
> +       /* Cards will not be in TRAN after completing identification comm=
ands
> +        * or MMC_SEND_STATUS if they are not selected.
> +        */
> +       return !(cmd->opcode =3D=3D MMC_SEND_CID
> +                       || cmd->opcode =3D=3D MMC_ALL_SEND_CID
> +                       || cmd->opcode =3D=3D MMC_SEND_CSD
> +                       || (cmd->opcode =3D=3D MMC_SEND_STATUS &&
> +                        MMC_EXTRACT_INDEX_FROM_ARG(cmd->arg) !=3D card->=
rca));
> +
> +}
> +
>  static int __mmc_blk_ioctl_cmd(struct mmc_card *card, struct mmc_blk_dat=
a *md,
>                                struct mmc_blk_ioc_data *idata)
>  {
> @@ -593,7 +607,8 @@ static int __mmc_blk_ioctl_cmd(struct mmc_card *card,=
 struct mmc_blk_data *md,
>
>         memcpy(&(idata->ic.response), cmd.resp, sizeof(cmd.resp));
>
> -       if (idata->rpmb || (cmd.flags & MMC_RSP_R1B) =3D=3D MMC_RSP_R1B) =
{
> +       if ((idata->rpmb || (cmd.flags & MMC_RSP_R1B))
> +                       && is_tran_transition_cmd(&cmd, card)) {

None of the commands you are checking for should have an R1B response
according to the spec, I think.

That said, I don't think we should do these kinds of sanity checks in
the kernel for the mmc ioctls, that just doesn't scale.

>                 /*
>                  * Ensure RPMB/R1B command has completed by polling CMD13
>                  * "Send Status".
> --

Kind regards
Uffe